SingleUpdatedNextEdit: Correctly apply insertion changes #281519
+27
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when changes are applied to a
SingleUpdatedNextEditinsertions are applied not entirely correctly.In case if:
We do the following:
What is the problem:
Why this is incorrect:
Here is an example:
If the user types
l, the system goes to this state:It is correct to assume that we only want to insert
o world";now, but we still want to replace"char.So we should move both start and end edge of replace range.
Fixes #281520