SH_Completion_Wait_For does not have any effect on EV3 motors

[AdmDeckerGH]

I know you apperently fixed this issue in the past.
But "SH_Completion_Wait_For" does not have any effect on running an EV3 motor.

[FloodJ]

What functions are you using? At a glance, motorRunSeconds appears to have code that uses SH_Completion_Wait_For, but it appears to be missing from motorRunTachometer.

[AdmDeckerGH]

I connected a large EV3 motor to bank A / M1 and tried these methods motorRunTachometer, motorRunSeconds, motorRunRotations, motorRunDegrees and passed "SH_Completion_Wait_For" in assumption the code would stop at this point until the motor did its job. But the code don't stop. In this example the motor don't turn for 3600 degrees because the motor gets resetted by the next line.

#include <EVShield.h>
EVShield evshield(0x34,0x36);

void setup()
{
evshield.init( SH_HardwareI2C );
evshield.bank_a.motorReset();
evshield.bank_a.motorRunDegrees(SH_Motor_1,
SH_Direction_Forward,
100,
3600,
SH_Completion_Wait_For,
SH_Next_Action_Brake);
evshield.bank_a.motorReset();
}

void loop()
{
}

[AdmDeckerGH]

Hi @FloodJ --
Do you have any suggestions on this ?
Thanks.

[FloodJ]

Sorry - I have't had a chance to test it myself yet. I've just traced through the code and found that the motorRunDegrees function depends on the motorIsTachoDone function, and that function is missing some pretty vital pieces of code. See issue #42 https://github.com/mindsensors/EVShield/issues/42 for the code to fix it.

[FloodJ]

And now that I've worked out Git I've created a fork with the patched code. Please download it from https://github.com/FloodJ/EVShield and test it.

[FloodJ]

Did the fix work for you, @AdmDeckerGH?