Non void functions that has no return statements (undefined behavior)

[JoakimCh]

I see a lot of functions in the code where the return statement is missing or is kept inside if blocks that may not execute. I am very surprised to see such badly written code which doesn't conform to any standards. Does anyone know the reasoning for this?

An example:

uint8_t EVShieldBank::motorWaitUntilTachoDone(SH_Motor which_motors)
{
  uint8_t s;
  delay(50);  // this delay is required for the status byte to be available for reading.
  s = motorIsTachoDone(which_motors);
  while (( s & SH_STATUS_TACHO ) != 0 ) {
    delay (50);
    s = motorIsTachoDone(which_motors);
  }
}

[pdingemans]

overall the code quality belonging to this shield is low. Unfortunately it is not possible to clean it because pull request are not granted. Reason for quality is not known to me.

[FloodJ]

#42, #45 and #47 are caused by that issue, and the function naming doesn't help - the names imply a boolean, but the functions that do return a value are uint8. My fork fixed #42 and #45, but I'm still learning Git so haven't got as far a pull request yet. I have found that a phone call gets a much faster response to issues in the past - it might be worth a try, especially if you're in the right time zone.