Lyrical Luth/Rolling Ament changes and cmakelist incompatibility.

[zewy9911-cmyk]

Description

There's a new ROS2 Rolling update which breaks Moveit2 due to Ament now being obsolete and new switch to target_link_libraries breaking the release build of moveit2.

ROS Distro

Rolling

OS and version

Ubuntu 24.04

Source or binary build?

Source

If binary, which release version?

No response

If source, which branch?

main/release/rolling

Which RMW are you using?

None

Steps to Reproduce

Update to latest ROS2 Rolling using apt, then try to rebuild moveit2, almost every single cmakelist breaks due to ament being broken.
Example:
--- stderr: rviz_visual_tools
CMake Error at CMakeLists.txt:243 (target_link_libraries):
The plain signature for target_link_libraries has already been used with
the target "rviz_visual_tools_rvt_test". All uses of target_link_libraries
with a target must be either all-keyword or all-plain.

The uses of the plain signature are here:

• /opt/ros/rolling/share/ament_cmake_gtest/cmake/ament_add_gtest_executable.cmake:53 (target_link_libraries)
• /opt/ros/rolling/share/ament_cmake_gtest/cmake/ament_add_gtest_executable.cmake:55 (target_link_libraries)
• /opt/ros/rolling/share/ament_cmake_gtest/cmake/ament_add_gtest_executable.cmake:59 (target_link_libraries)

Expected behavior

It should build with no cmake errors.

Actual behavior

It errors out on most moveit2 packages.

Backtrace or Console output

No response