Notch not hiding on non notch device

[daniyalmaster693]

Hi, maybe you can point me in the right direction, but I have this issue where on a non notch display the notch will sometimes hide normally and sometimes persist like this:

Could this just be because I'm using a non notch display which wasn't the intended use case? I've noticed sometimes it hides completely, but will reappear if I plug in another display as well.

Relevant code:

https://github.com/daniyalmaster693/MenuScores/blob/main/MenuScores/MenuScoresApp.swift#L1060
https://github.com/daniyalmaster693/MenuScores/blob/main/MenuScores/Utils/NotchManager.swift

[daniyalmaster693]

I found the issue. You need to add a guard so the observeScreenParameters function does not re initialize the notch window even if it is hidden.

private func observeScreenParameters() {
        Task {
            let sequence = NotificationCenter.default.notifications(named: NSApplication.didChangeScreenParametersNotification)
            for await _ in sequence.map(\.name) {
                guard self.state != .hidden else { continue }

                if let screen = NSScreen.screens.first {
                    initializeWindow(screen: screen)
                }
            }
        }
    }