Skip to content

Commit bcb786d

Browse files
committed
Finished websocket tests
1 parent c5b5d25 commit bcb786d

1 file changed

Lines changed: 13 additions & 12 deletions

File tree

‎test_package/websockets_rest_sink_test.cpp‎

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -640,22 +640,23 @@ TEST_F(WebsocketsRestSinkTest, should_return_error_for_malformed_json)
640640
}
641641
}
642642

643-
TEST_F(WebsocketsRestSinkTest, should_return_error_for_unknown_parameter)
644-
{
645-
GTEST_SKIP() << "Test not implemented yet";
646-
}
647-
648643
TEST_F(WebsocketsRestSinkTest, should_return_error_for_unknown_device)
649644
{
650-
GTEST_SKIP() << "Test not implemented yet";
645+
{
646+
PARSE_XML_WS_RESPONSE(R"({ "id": "1", "request": "probe", "device": "XyzAbc"})");
647+
ASSERT_XML_PATH_EQUAL(doc, "//m:InvalidURI@errorCode", "INVALID_URI");
648+
ASSERT_XML_PATH_EQUAL(doc, "//m:ErrorMessage", "0.0.0.0:");
649+
}
651650
}
652651

653652
TEST_F(WebsocketsRestSinkTest, should_return_error_for_bad_parameter_value)
654653
{
655-
GTEST_SKIP() << "Test not implemented yet";
656-
}
657-
658-
TEST_F(WebsocketsRestSinkTest, should_coerce_parameter_data_types)
659-
{
660-
GTEST_SKIP() << "Test not implemented yet";
654+
{
655+
PARSE_XML_WS_RESPONSE(
656+
R"({ "id": "1", "request": "current", "format": "xml", "at": "notanumber" })");
657+
ASSERT_XML_PATH_EQUAL(doc, "//m:InvalidParameterValue@errorCode", "INVALID_PARAMETER_VALUE");
658+
ASSERT_XML_PATH_EQUAL(
659+
doc, "//m:ErrorMessage",
660+
"query parameter 'at': invalid type, expected uint64");
661+
}
661662
}

0 commit comments

Comments
 (0)