merged transaction-commit-bug into main

Author: transistive

src/Bolt/BoltConnection.php

@@ -46,7 +46,19 @@ final class BoltConnection implements ConnectionInterface
     private BoltFactory $factory;
 
     private string $serverState = 'DISCONNECTED';
-    /** @var list<WeakReference<CypherList>> */
+    /**
+     * @note We are using references to "subscribed results" to maintain backwards compatibility and try and strike
+     *       a balance between performance and ease of use.
+     *       The connection will discard or pull the results depending on the server state transition. This way end
+     *       users don't have to worry about consuming result sets, it will all happen behind te scenes. There are some
+     *       edge cases where the result set will be pulled or discarded when it is not strictly necessary, and we
+     *       should introduce a "manual" mode later down the road to allow the end users to optimise the result
+     *       consumption themselves.
+     *       A great moment to do this would be when neo4j 5 is released as it will presumably allow us to do more
+     *       stuff with PULL and DISCARD messages.
+     *
+     * @var list<WeakReference<CypherList>>
+     */
     private array $subscribedResults = [];
 
     /**

tests/Integration/BoltResultIntegrationTest.php

@@ -19,6 +19,7 @@
 use Laudis\Neo4j\Authentication\Authenticate;
 use Laudis\Neo4j\Bolt\BoltConnection;
 use Laudis\Neo4j\Bolt\BoltResult;
+use Laudis\Neo4j\Bolt\SslConfigurator;
 use Laudis\Neo4j\BoltFactory;
 use Laudis\Neo4j\Common\ConnectionConfiguration;
 use Laudis\Neo4j\Common\Uri;
@@ -59,6 +60,10 @@ public function testIterationLong(string $connection): void
     {
         $uri = Uri::create($connection);
         $socket = new StreamSocket($uri->getHost(), $uri->getPort() ?? 7687);
+        $options = (new SslConfigurator())->configure($uri, DriverConfiguration::default());
+        if ($options !== null) {
+            $socket->setSslContextOptions($options);
+        }
 
         $i = 0;
         $factory = new BoltFactory(new Bolt($socket), Authenticate::fromUrl($uri), '', $socket);