Skip to content

fix(screenshots): Remove focus outlines from documentation screenshots#2515

Merged
miaulalala merged 1 commit intomasterfrom
fix/screenshot-focus-outlines
Apr 15, 2026
Merged

fix(screenshots): Remove focus outlines from documentation screenshots#2515
miaulalala merged 1 commit intomasterfrom
fix/screenshot-focus-outlines

Conversation

@miaulalala
Copy link
Copy Markdown
Collaborator

Blur focused elements after clicking navigation items and sidebar tabs so that browser focus outlines do not appear in the captured screenshots.

AI-Assisted-By: Claude Opus 4.6 noreply@anthropic.com

@miaulalala miaulalala added this to the Nextcloud 34 milestone Apr 15, 2026
@miaulalala miaulalala requested a review from artonge April 15, 2026 07:23
@miaulalala miaulalala self-assigned this Apr 15, 2026
@miaulalala miaulalala added 3. to review github_actions Pull requests that update GitHub Actions code labels Apr 15, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@cypress
Copy link
Copy Markdown

cypress bot commented Apr 15, 2026

Activity    Run #3599

Run Properties:  status check passed Passed #3599  •  git commit b97f924719: fix(screenshots): Remove focus outlines from documentation screenshots
Project Activity
Branch Review fix/screenshot-focus-outlines
Run status status check passed Passed #3599
Run duration 02m 13s
Commit git commit b97f924719: fix(screenshots): Remove focus outlines from documentation screenshots
Committer Anna
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 16
View all changes introduced in this branch ↗︎

Blur focused elements after clicking navigation items and sidebar tabs
so that browser focus outlines do not appear in the captured screenshots.

AI-Assisted-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the fix/screenshot-focus-outlines branch from 4646def to cd61b08 Compare April 15, 2026 08:36
Copy link
Copy Markdown
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And now guess what I am listening too? 👧s & 👦s 🎵

Copy link
Copy Markdown
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And now guess what I am listening too? 👧s & 👦s 🎵

@miaulalala miaulalala merged commit 82dcaf8 into master Apr 15, 2026
53 checks passed
@miaulalala miaulalala deleted the fix/screenshot-focus-outlines branch April 15, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants