feat: add oc-ownerid and oc-permissions headers on PUT DAV requests #54542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmart-dev
requested review from
come-nc,
sorbaugh and
yemkareems
and removed request for
a team
come-nc
requested changes
Aug 21, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
New non-standard headers should be prefixed with X-
susnux
reviewed
Aug 21, 2025
susnux
reviewed
Aug 21, 2025
come-nc
reviewed
Aug 25, 2025
susnux
reviewed
Aug 26, 2025
come-nc
approved these changes
Aug 28, 2025
4 tasks
Contributor
Author
|
The last three commits add the changes necessary to add the filtering logic to hide mount and share information from the permission string, under Robin's suggestion that the behaviour should be kept. |
salmart-dev
force-pushed
the
54088-providePermissionsAndOwnerIdInPut
branch
from
a62a217 to
dd52669
Compare
salmart-dev
force-pushed
the
54088-providePermissionsAndOwnerIdInPut
branch
from
f40f9a6 to
035f7cd
Compare
salmart-dev
force-pushed
the
54088-providePermissionsAndOwnerIdInPut
branch
from
035f7cd to
81a7bf9
Compare
Contributor
Author
|
Last update 🤞 : the fixes with |
Contributor
Author
Right, I think in this case a good option would be to add a new |
The permission string for directories and files can contain M or S depending if they are respectively coming from a mount or a share. This information is not to be disclosed when the share is a public one. Signed-off-by: Salvatore Martire <[email protected]>
Signed-off-by: Salvatore Martire <[email protected]>
salmart-dev
force-pushed
the
54088-providePermissionsAndOwnerIdInPut
branch
from
44ef5c0 to
0b577ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
OC-PermissionsandOC-OwnerIdheaders to the response of PUT DAV requests.Documentation update: nextcloud/documentation#13525
Checklist