fix: Allow installation on macOS CI #56900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Müller <[email protected]>
SystemKeeper
requested review from
ArtificialOwl,
CarlSchwan,
icewind1991,
joshtrichards,
nickvergessen and
yemkareems
and removed request for
a team
nickvergessen
approved these changes
Dec 7, 2025
come-nc
reviewed
Dec 8, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
I’m lost, this looks like it allows installation on macOS but only on CI, not in normal environment. What’s the point?
Contributor
Author
|
That’s exactly what it is. So the previous PR prevented (accidentally) installation on macOS, breaking CI, but we need to be able to run it on CI, at least for now. We can surely discuss if installation should be possible in general again, for now we need it at least for CI |
Member
|
Merging so the ios talk app has CI again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OC_Utilmethod...runningOnMac();-) #56816Summary
Because of the string change in the mentioned PR, installation on macOS is not possible anymore. Since the current macOS runner on GitHub do not support nested virtualization (therefore something like Docker will not work), we currently require being able to run on macOS.
Thanks @nickvergessen for preparation!
Checklist
3. to review, feature component)stable32)