second user cursor deletes text, prevents newline and inserts username as text

[kolAflash]

Describe the bug
@juliushaertl This is a follow up for regressions since >= 26.0, already described in #5102 and #4100

Since Nextcloud 26.0, there is strange behaviour if a user cursor is present.

 

To Reproduce
A webbrowser (Firefox-120.0.1 on Debian-12) is having the file opened simultaneously. But I'm doing nothing on the webbrowser client. It just has the file opened.

Please see the attached videos for behaviour and reproduction. (recorded on Android)
Mind the Return and Backspace keys flashing when I press them.

VIDEOS

https://github.com/nextcloud/text/assets/3355089/310995e5-b0eb-4efa-bceb-10b47388fc3b

NC-26.0.9_adds-username-as-text.mp4

 

Expected behavior
Text should not be deleted on pressing Return. (related #1927)
Adding a newline (Return) at a user cursor position should work.
Username should not be added as text when pressing backspace at a user cursor position.

(slightly related #5102)

 

Server details:
Tested with two different servers.

• server 1
  • Nextcloud version: 26.0.9
  • PHP Version: 8.2 (Debian-12)
  • Database: MariaDB 10.11.4 (Debian-12)
• server 2
  • Nextcloud version: 27.1.1.0
  • PHP Version: unknown
  • Database: unkonwn

 

Client details:
Tested with two different Android devices.

• Device: Fairphone 3+
  • Nextcloud app: 3.26.0
  • OS: /e/OS-12.3-s (LineageOS-19 based Android-12)
• Device: Google Pixel 4a
  • Nextcloud app: 3.26.0
  • OS: Android-13

[jospoortvliet]

Odd. This is specific to .txt files, doesn't happen in MD files?

I see you can only make 1 free line, on Text on iOS in a .txt file, but the other stuff doesn't happen. This might also be keyboard/autocomplete doing weirdo things I guess.

[kolAflash]

MD files behave buggy in a slightly different way.

video with OpenBoard and a MD file on a Fairephone 3 (e/OS/, AOSP Keyboard)

recording_20240214_173900.mp4

Same test result on the Fairphone 3 (e/OS/) and the Nokia 1 (TA-1060).

 

Fairphone 3 (e/OS/) uses "AOSP Keyboard".
Switching to Hacker's Keyboard seems to workaround the issue.

Google Pixel 4a uses OpenBoard.
Nokia 1 uses OpenBoard too.

Using Google GBoard changes the behavior slightly. Newlines work with GBoard. Deleting a line (backspace) with another user cursor does only work in MD files, but not in TXT files.

 

So the behavior with "AOSP Keyboard" and OpenBoard is broken. GBoard partly works. And only "Hacker's Keyboard" works fine.

[kolAflash]

@jospoortvliet
Find the answers to your questions in my previous comment.

 

I'm getting really annoyed with this.
Since Nextcloud-26 came out about one year ago the text app is broken in many ways!
Especially on Android!

Unintentionally deleted text / data loss happen again and again since Nextcloud >= 26.

 

I invested a lot of time in exactly describing those bugs. But still the text app suffers from a lot of problems which didn't exist in Nextcloud-25.
#4100 user cursors trigger different bugs (2023-05)
#5102 Android app text editor doesn't write changes to server filesystem
Please feel free to ask me for anything I can provide.
(I'm a software developer myself and if I would have more knowledge of the Nextcloud source, I'd fix this mess myself. I just don't have enough time to properly work into the Nextcloud source so I can fix complicated synchronization issues.)

Here's another bug video I created when my shopping list TXT file was smashed today.
(Android-App-3.29.0, Nextcloud-Server-28.0.5, AOSP keyboard, eOS / Android-12)
https://github.com/nextcloud/text/assets/3355089/d1b4cc7a-a900-477a-93b3-8cd16040afbb

 

I've experienced those problems with multiple servers and on multiple end devices. So I'm very likely not the only one suffering from it. And having the constant risk of data loss (unintentionally deleted text, unsaved files) is a really bad thing for the user!

The people who introduced the changes between Nextcloud 25 and 26 (apparently mostly adding user cursors) should have a look at the resulting regressions.
And if no one has the resources to fix this, I suggest reverting changes which added the users cursors feature.
Those user cursors are really not worth the trouble!!!

 

Kind regards and thanks for your work,
kolAflash

[RoWo-DS]

We experience random text deletion and deactivated the text app for that reason. We use

• Nextcloud Hub 8 (29.0.6)
• Text 3.10.1

It would be great, if someone could fix that problem or recommend another app, which doesn't randomly delete text.

[mejo-]

Several improvements and bugfixes were added to collaborative editing in the meantime. Could you please open a new issue if you still experience issues with it?

[kolAflash]

Issue still exists as described in the initial message.

Last tested versions
Nextcloud: 32.0.0.13
NC-Android-App: 3.33.0
Android: Android-13 (/e/OS-3.0.4-t)
Keyboard: AOSP (by /e/OS-3.0.4)

Happens in TXT files and in MD.
For MD happens on a line inside as well as at the end of a paragraph.

[mejo-]

@kolAflash thanks for reporting this again! Can you try to reproduce this in the Tiptap example editor with collaboration cursor here: https://tiptap.dev/docs/editor/extensions/functionality/collaboration-caret

[kolAflash]

@kolAflash thanks for reporting this again! Can you try to reproduce this in the Tiptap example editor with collaboration cursor here: https://tiptap.dev/docs/editor/extensions/functionality/collaboration-caret

Yes. Happens between the upper and lower tiptap demo edit field when opened in Fennec-142.0.1 (~Firefox) on my phone.

[mejo-]

This prosemirror issue might be related: ProseMirror/prosemirror#565