Skip to content

feat(editor): add support for highlighting text#8309

Open
mejo- wants to merge 1 commit intomainfrom
feat/highlight
Open

feat(editor): add support for highlighting text#8309
mejo- wants to merge 1 commit intomainfrom
feat/highlight

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented Mar 6, 2026

Uses Tiptap Highlight extension and markdown-it mark plugin.

Fixes: #1575

🖼️ Screenshots

🏚️ Before 🏡 After
before after

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Uses Tiptap Highlight extension and markdown-it mark plugin.

Fixes: #1575

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- self-assigned this Mar 6, 2026
@mejo- mejo- requested a review from max-nextcloud as a code owner March 6, 2026 14:05
@mejo- mejo- requested a review from silverkszlo as a code owner March 6, 2026 14:05
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/Menu/entries.ts 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@mejo- mejo- added the enhancement New feature or request label Mar 6, 2026
@mejo- mejo- requested a review from marcoambrosini March 6, 2026 14:25
@marcoambrosini
Copy link
Member

Suggestion for highlight colors:

  • Light theme - #fff0c7
Screenshot 2026-03-09 at 14 56 25 * Dark theme - #4d3800 Screenshot 2026-03-09 at 14 57 03

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed the code. Did not test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark text as highlighted

3 participants