Merged
Conversation
* Drop unused `$file.document`. * Make file props optional as they might not be injected. * Rename `lastFilePath` to `startPath` as that is used elsewhere. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
chore/use-file-composable
branch
from
f2c11ef to
ed55ac9
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
mejo-
approved these changes
Mar 9, 2026
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Code changes look good to me, thanks for looking into this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$file.document.lastFilePathtostartPathas that is used elsewhere.Preparation for fixing the
OC.Filesusage in current main branch