Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
max-nextcloud
force-pushed
the
chore/fix-flaky-cypress-attachment-test
branch
3 times, most recently
from
39a3c30 to
7cc9623
Compare
max-nextcloud
commented
Mar 9, 2026
| .should('have.attr', 'data-cy-files-list-row-fileid') | ||
| .then((documentId) => { | ||
| const files = attachmentFileNameToId[documentId] | ||
| cy.get('@createdFileId').should('eq', parseInt(documentId)) |
Collaborator
Author
There was a problem hiding this comment.
In the failing tests it looks as if the .attachments folder has a different id then expected. So compare the ids first to see if the id changed when moving the file.
Also disable retries as the subfolder cannot be created twice so all retries fail anyways. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
chore/fix-flaky-cypress-attachment-test
branch
from
7cc9623 to
7690b00
Compare
Collaborator
Author
|
/backport to main please |
Collaborator
Author
|
/backport to stable32 please |
mejo-
approved these changes
Mar 9, 2026
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Thanks for investigating, looks sensible to me. I wonder whether we should also forward-port this to main?
Member
Ah just saw you already requested this 😉 |
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests have been passing since i pushed this. And I tried them several times. But anyways - with these changes the next test failure will hopefully have a more meaningful output:
Failures before
Note how there is an attachments folder - just with a different id.