Skip to content

Remove vulnerable PR-comment artifact pattern - #103

Merged
mashehu merged 1 commit into
masterfrom
patch
Jul 28, 2026
Merged

Remove vulnerable PR-comment artifact pattern#103
mashehu merged 1 commit into
masterfrom
patch

Conversation

@mashehu

@mashehu mashehu commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Security patch

This PR applies a security fix included in nf-core/tools 4.0.3 for a potential exploit in the GitHub Actions workflows that post comments on pull requests.

For details, see the related security advisory: https://nf-co.re/advisories/pr-comment-workflow-vulnerability

The fix must be merged into the default branch to take effect. Please merge this PR as soon as possible.

These changes only affect CI workflows, so merging them into the default branch does not require a new pipeline release.

These files conflicted with the patch and were reset wholesale to the nf-core/tools 4.0.3 template version, on the basis that they carry no pipeline-specific content. If this branch had local edits in them, those edits are gone — please review: .github/workflows/branch.yml .github/workflows/template-version-comment.yml
@nf-core-bot

Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@github-actions

Copy link
Copy Markdown

nf-core pipelines lint overall result: Failed ❌

Posted for pipeline commit 406883a

+| ✅ 219 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   5 tests had warnings |!
-| ❌   2 tests failed       |-
Details

❌ Test failures:

  • nextflow_config - Config default value incorrect: params.taxa_sqlite is set as [:]/genomics/prokaryotes/metagenome/taxonomy/misc/taxa_sqlite.xz in nextflow_schema.json but is null/genomics/prokaryotes/metagenome/taxonomy/misc/taxa_sqlite.xz in nextflow.config.
  • nextflow_config - Config default value incorrect: params.taxa_sqlite_traverse_pkl is set as [:]/genomics/prokaryotes/metagenome/taxonomy/misc/taxa_sqlite_traverse.pkl in nextflow_schema.json but is null/genomics/prokaryotes/metagenome/taxonomy/misc/taxa_sqlite_traverse.pkl in nextflow.config.

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File does not exist: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-coproid_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-coproid_logo_dark.png

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.2
  • Run at 2026-07-28 09:40:29

@mashehu
mashehu merged commit 2843c59 into master Jul 28, 2026
11 of 13 checks passed
@mashehu
mashehu deleted the patch branch July 28, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants