Remove maximum snippet size validation from SnippetsPolicy

Author: fabian4

internal/controller/nginx/config/policies/snippetspolicy/validator.go

@@ -77,8 +77,6 @@ func (v *Validator) Conflicts(polA, polB policies.Policy) bool {
 	return false
 }
 
-const maxSnippetSize = 2048 // 2KB
-
 func validateSnippets(snippets []ngfAPI.Snippet) error {
 	seenContexts := make(map[ngfAPI.NginxContext]struct{})
 	for _, snippet := range snippets {
@@ -90,10 +88,6 @@ func validateSnippets(snippets []ngfAPI.Snippet) error {
 		if snippet.Context == ngfAPI.NginxContextHTTPServerLocation {
 			return fmt.Errorf("context %q is not supported in SnippetsPolicy", snippet.Context)
 		}
-
-		if len(snippet.Value) > maxSnippetSize {
-			return fmt.Errorf("snippet value for context %q exceeds maximum size of %d bytes", snippet.Context, maxSnippetSize)
-		}
 	}
 	return nil
 }

internal/controller/nginx/config/policies/snippetspolicy/validator_test.go

@@ -120,21 +120,6 @@ func TestValidator_Validate(t *testing.T) {
 				conditions.NewPolicyInvalid("context \"http.server.location\" is not supported in SnippetsPolicy"),
 			},
 		},
-		{
-			name: "snippet too large",
-			policy: createModifiedPolicy(func(p *ngfAPI.SnippetsPolicy) *ngfAPI.SnippetsPolicy {
-				p.Spec.Snippets = []ngfAPI.Snippet{
-					{
-						Context: ngfAPI.NginxContextMain,
-						Value:   string(make([]byte, 2049)),
-					},
-				}
-				return p
-			}),
-			expConditions: []conditions.Condition{
-				conditions.NewPolicyInvalid("snippet value for context \"main\" exceeds maximum size of 2048 bytes"),
-			},
-		},
 	}
 
 	v := snippetspolicy.NewValidator()