Skip to content

Commit 49e2608

Browse files
deepak1556nodejs-github-bot
authored andcommitted
deps: enable V8 API interrupt JS check
Signed-off-by: deepak1556 <hop2deep@gmail.com> PR-URL: #65397 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
1 parent 30f4990 commit 49e2608

2 files changed

Lines changed: 11 additions & 0 deletions

File tree

‎common.gypi‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@
5454
# Refs: https://github.com/nodejs/node/issues/23167
5555
# Enable compiler warnings when using V8_DEPRECATED apis from V8 code.
5656
'v8_deprecation_warnings': 0,
57+
# Check that JavaScript execution is disallowed in V8 API interrupts.
58+
'v8_disallow_js_in_api_interrupts_is_checked': 1,
5759
# Enable compiler warnings when using V8_DEPRECATE_SOON apis from V8 code.
5860
'v8_imminent_deprecation_warnings': 0,
5961

@@ -534,6 +536,9 @@
534536
['v8_deprecation_warnings == 1', {
535537
'defines': ['V8_DEPRECATION_WARNINGS',],
536538
}],
539+
['v8_disallow_js_in_api_interrupts_is_checked == 1', {
540+
'defines': ['V8_DISALLOW_JS_IN_API_INTERRUPTS_IS_CHECKED',],
541+
}],
537542
['v8_imminent_deprecation_warnings == 1', {
538543
'defines': ['V8_IMMINENT_DEPRECATION_WARNINGS',],
539544
}],

‎tools/v8_gypfiles/features.gypi‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,9 @@
107107
# Enable compiler warnings when using V8_DEPRECATED apis.
108108
'v8_deprecation_warnings%': 0,
109109

110+
# Check that JavaScript execution is disallowed in V8 API interrupts.
111+
'v8_disallow_js_in_api_interrupts_is_checked%': 0,
112+
110113
# Enable compiler warnings when using V8_DEPRECATE_SOON apis.
111114
'v8_imminent_deprecation_warnings%': 0,
112115

@@ -417,6 +420,9 @@
417420
['v8_deprecation_warnings==1', {
418421
'defines': ['V8_DEPRECATION_WARNINGS',],
419422
}],
423+
['v8_disallow_js_in_api_interrupts_is_checked==1', {
424+
'defines': ['V8_DISALLOW_JS_IN_API_INTERRUPTS_IS_CHECKED',],
425+
}],
420426
['v8_imminent_deprecation_warnings==1', {
421427
'defines': ['V8_IMMINENT_DEPRECATION_WARNINGS',],
422428
}],

0 commit comments

Comments
 (0)