Skip to content

Commit c12d483

Browse files
panvanodejs-github-bot
authored andcommitted
test: unmark exit timeout tests as flaky
Background compilation could deadlock at process exit: DrainTasks waited for the compiler task while that task waited for main-thread garbage collection. Since 5fb879c, only user-blocking tasks count toward that wait, excluding ordinary background compilation. Remove the old flaky expectations for test-http2-large-file and test-fs-read-stream-concurrent-reads. Refs: #47409 Refs: #51862 Refs: #54918 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex PR-URL: #66319 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 1a15692 commit c12d483

2 files changed

Lines changed: 0 additions & 5 deletions

File tree

‎test/parallel/parallel.status‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ prefix parallel
99
test-shadow-realm-gc: SKIP
1010
test-shadow-realm-gc-module: SKIP
1111

12-
# https://github.com/nodejs/node/issues/51862
13-
test-fs-read-stream-concurrent-reads: PASS, FLAKY
14-
1512
# Until V8 provides a better way to check for flag mismatch without
1613
# making the code cache/snapshot unreproducible, disable the test
1714
# for a preemptive check now. It should ideally fail more gracefully

‎test/sequential/sequential.status‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ prefix sequential
55
# sample-test : PASS,FLAKY
66

77
[true] # This section applies to all platforms
8-
# https://github.com/nodejs/node/issues/47409
9-
test-http2-large-file: PASS, FLAKY
108

119
[$system==win32]
1210
# https://github.com/nodejs/node/issues/63212#issuecomment-5423558796

0 commit comments

Comments
 (0)