Skip to content

Commit ec0bb3e

Browse files
committed
deps: V8: cherry-pick 95626c699ff2
Original commit message: [objects] Use a generic lambda for gc_retry in BackingStore gc_retry passes a std::function<bool()> as base::FunctionRef, which derives the signature from decltype(&Functor::operator()), whose type is unspecified by the standard, and it fails to compile with MSVC STL. Use a generic lambda so FunctionRef binds to the caller's lambda directly. Co-Authored-By: StefanStojanovic <stefan.stojanovic@janeasystems.com> Refs: #61898 Change-Id: I9ce000ed3136942577b1a6da0b890bc48d0f00e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8517726 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#110418} Refs: v8/v8@95626c6 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
1 parent eb6f2ff commit ec0bb3e

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎common.gypi‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444

4545
# Reset this number to 0 on major V8 upgrades.
4646
# Increment by one for each non-official patch applied to deps/v8.
47-
'v8_embedder_string': '-node.6',
47+
'v8_embedder_string': '-node.7',
4848

4949
##### V8 defaults for Node.js #####
5050

‎deps/v8/src/objects/backing-store.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ std::unique_ptr<BackingStore> BackingStore::TryAllocateAndPartiallyCommitMemory(
323323
// For accounting purposes, whether a GC was necessary.
324324
bool did_retry = false;
325325

326-
auto gc_retry = [&](const std::function<bool()>& fn) {
326+
auto gc_retry = [&](const auto& fn) {
327327
if (fn()) return true;
328328
// Collect garbage and retry.
329329
did_retry = true;

0 commit comments

Comments
 (0)