Skip to content

Commit 7576a58

Browse files
committed
feat(i18n): run eloqnt lint in CI quality checks
Adds a root lint:i18n script following the same pattern as the root prettier task: the tool spans apps/site and packages/i18n, so it is installed at the workspace root and wired into the Quality checks job via a turbo root task. Also shortens the config comment per review.
1 parent 6d81cb3 commit 7576a58

4 files changed

Lines changed: 7 additions & 6 deletions

File tree

‎.eloqnt/config.ts‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,8 @@ export default defineConfig({
1414
lint: {
1515
overrides: [
1616
{
17-
// These keys are built at runtime, so static analysis cannot see
18-
// them being used: labels come from navigation.json and
19-
// constants.json (e.g. t(link.text)), and the remaining keys are
20-
// built from a template with a runtime value, e.g.
21-
// t(`components.eolChip.severity.${severity}`).
17+
// These keys are built at runtime, so static analysis cannot
18+
// see which ones are in use.
2219
keys: [
2320
'components.containers.footer.links.*',
2421
'components.containers.navBar.links.*',

‎.github/workflows/lint-and-tests.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
if: |
7474
(github.event_name == 'push' || github.event_name == 'merge_group') ||
7575
(github.event_name == 'pull_request' && github.event.pull_request.head.ref != 'chore/crowdin')
76-
run: node_modules/.bin/turbo lint lint:types prettier --cache-dir=.turbo/cache
76+
run: node_modules/.bin/turbo lint lint:types prettier //#lint:i18n --cache-dir=.turbo/cache
7777

7878
- name: Save Lint Cache
7979
# We only want to save caches on `push` events or `pull_request_target` events

‎package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
"format": "turbo //#prettier:fix prettier:fix lint:fix",
2222
"lint": "turbo lint",
2323
"lint:fix": "turbo lint:fix",
24+
"lint:i18n": "eloqnt lint",
2425
"lint:staged": "lint-staged",
2526
"lint:types": "turbo lint:types",
2627
"prepare": "husky",

‎turbo.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
"$schema": "https://turbo.build/schema.json",
33
"dangerouslyDisablePackageManagerCheck": true,
44
"tasks": {
5+
"//#lint:i18n": {
6+
"inputs": [".eloqnt/**", "apps/site/**", "packages/i18n/src/**"]
7+
},
58
"//#prettier": {
69
"outputs": [".prettiercache"]
710
},

0 commit comments

Comments
 (0)