From 4cc5a4db1a4290593c095ec8f06c10c5df38b493 Mon Sep 17 00:00:00 2001 From: Jason Karns Date: Sun, 18 Jan 2026 15:44:38 -0500 Subject: [PATCH 1/4] RUN_LOCAL is no longer necessary since superlinter 8.4 --- .github/workflows/.github_test.yml | 8 +++----- .github/workflows/test.yml | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/.github_test.yml b/.github/workflows/.github_test.yml index f801ab6..a0afdef 100644 --- a/.github/workflows/.github_test.yml +++ b/.github/workflows/.github_test.yml @@ -50,12 +50,10 @@ jobs: with: repository: nodenv/${{ matrix.repo }} persist-credentials: false - - uses: super-linter/super-linter/slim@d5b0a2ab116623730dd094f15ddc1b6b25bf7b99 # v8.3.2 + - uses: super-linter/super-linter/slim@12562e48d7059cf666c43a4ecb0d3b5a2b31bd9e # v8.4.0 env: - ### RUN_LOCAL+USE_FIND_ALGORITHM to workaround superlinter - RUN_LOCAL: true - USE_FIND_ALGORITHM: true - ### + USE_FIND_ALGORITHM: true # workaround superlinter + ### below here should match our reusable test workflow config GITHUB_TOKEN: ${{ github.token }} BASH_EXEC_IGNORE_LIBRARIES: true # superlinter bug #5731 FILTER_REGEX_EXCLUDE: node_modules diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index bbcbc90..79f7e54 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -39,7 +39,7 @@ jobs: with: { egress-policy: audit } - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: { fetch-depth: 0, persist-credentials: false } - - uses: super-linter/super-linter/slim@d5b0a2ab116623730dd094f15ddc1b6b25bf7b99 # v8.3.2 + - uses: super-linter/super-linter/slim@12562e48d7059cf666c43a4ecb0d3b5a2b31bd9e # v8.4.0 env: GITHUB_TOKEN: ${{ github.token }} BASH_EXEC_IGNORE_LIBRARIES: true # superlinter bug From 5f23a4632d9704d60559f9668477ab62b50746a1 Mon Sep 17 00:00:00 2001 From: Jason Karns Date: Sun, 1 Feb 2026 15:46:20 -0500 Subject: [PATCH 2/4] Disable codespell for now --- .github/workflows/.github_test.yml | 1 + .github/workflows/test.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/.github_test.yml b/.github/workflows/.github_test.yml index a0afdef..676abda 100644 --- a/.github/workflows/.github_test.yml +++ b/.github/workflows/.github_test.yml @@ -61,3 +61,4 @@ jobs: VALIDATE_BIOME_LINT: false # conflicts with prettier VALIDATE_GIT_COMMITLINT: false # commitlint is bad VALIDATE_JSCPD: false # too prone to false-positives + VALIDATE_SPELL_CODESPELL: false # TODO diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 79f7e54..27d6292 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -48,6 +48,7 @@ jobs: VALIDATE_BIOME_LINT: false # conflicts with prettier VALIDATE_GIT_COMMITLINT: false # commitlint is bad VALIDATE_JSCPD: false # too prone to false-positives + VALIDATE_SPELL_CODESPELL: false # TODO dependency-review: if: startsWith('pull_request', github.event_name) From 07eceea43533450c49520b74890610308902fe15 Mon Sep 17 00:00:00 2001 From: Jason Karns Date: Sun, 8 Feb 2026 15:05:44 -0500 Subject: [PATCH 3/4] Can't use zizmor in shared reusible workflow See https://github.com/zizmorcore/zizmor/issues/1585 Zizmor is currently limited to be unable to tell what is a local action (local to the same github organization). As such, it cannot treat reusable workflows as "local", and thus considers non-sha-pinned workflows as a violation. And since there isn't any way to override this setting without creating a zizmor config _in every repo_, we must sadly disable the entire linter. It's possible that a future enhancement will allow us to create a single shared configuration: https://github.com/orgs/zizmorcore/discussions/1142 But until that time, this linter is not worth the maintenance overhead. --- .github/workflows/.github_test.yml | 1 + .github/workflows/test.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/.github_test.yml b/.github/workflows/.github_test.yml index 676abda..41be370 100644 --- a/.github/workflows/.github_test.yml +++ b/.github/workflows/.github_test.yml @@ -60,5 +60,6 @@ jobs: VALIDATE_BIOME_FORMAT: false # conflicts with prettier VALIDATE_BIOME_LINT: false # conflicts with prettier VALIDATE_GIT_COMMITLINT: false # commitlint is bad + VALIDATE_GITHUB_ACTIONS_ZIZMOR: false VALIDATE_JSCPD: false # too prone to false-positives VALIDATE_SPELL_CODESPELL: false # TODO diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 27d6292..3a6c8e3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -47,6 +47,7 @@ jobs: VALIDATE_BIOME_FORMAT: false # conflicts with prettier VALIDATE_BIOME_LINT: false # conflicts with prettier VALIDATE_GIT_COMMITLINT: false # commitlint is bad + VALIDATE_GITHUB_ACTIONS_ZIZMOR: false VALIDATE_JSCPD: false # too prone to false-positives VALIDATE_SPELL_CODESPELL: false # TODO From 0ea86bfacdd8228731eaded9cb8cfaf37bf04066 Mon Sep 17 00:00:00 2001 From: Jason Karns Date: Sun, 8 Feb 2026 15:20:26 -0500 Subject: [PATCH 4/4] Bump superlinter to 8.5.0 --- .github/workflows/.github_test.yml | 2 +- .github/workflows/test.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/.github_test.yml b/.github/workflows/.github_test.yml index 41be370..631ad10 100644 --- a/.github/workflows/.github_test.yml +++ b/.github/workflows/.github_test.yml @@ -50,7 +50,7 @@ jobs: with: repository: nodenv/${{ matrix.repo }} persist-credentials: false - - uses: super-linter/super-linter/slim@12562e48d7059cf666c43a4ecb0d3b5a2b31bd9e # v8.4.0 + - uses: super-linter/super-linter/slim@61abc07d755095a68f4987d1c2c3d1d64408f1f9 # v8.5.0 env: USE_FIND_ALGORITHM: true # workaround superlinter ### below here should match our reusable test workflow config diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3a6c8e3..b0ebdc4 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -39,7 +39,7 @@ jobs: with: { egress-policy: audit } - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: { fetch-depth: 0, persist-credentials: false } - - uses: super-linter/super-linter/slim@12562e48d7059cf666c43a4ecb0d3b5a2b31bd9e # v8.4.0 + - uses: super-linter/super-linter/slim@61abc07d755095a68f4987d1c2c3d1d64408f1f9 # v8.5.0 env: GITHUB_TOKEN: ${{ github.token }} BASH_EXEC_IGNORE_LIBRARIES: true # superlinter bug