Skip to content

Remove workaround in NotificationDrawer unit test #210

Description

@jon-nfc
  • if( allowedErrors['has_action_menu'] == consoleErrorSpy.mock.calls[0][0] ) {
    /**
    * To Do: FixMe
    * Upstream:
    * Bug: https://github.com/patternfly/patternfly-react/issues/12295
    * PR: https://github.com/patternfly/patternfly-react/pull/12315
    *
    * There is a bug in PatternFly when used with react 19. in my case
    * the file in question was `/home/sysadmin/git/centurion-erp-ui/node_modules/@patternfly/react-core/dist/js/components/Drawer/DrawerPanelContent.js`
    *
    * Issue presented itself when updating to `@patternfly/react-core@6.5.1`
    * version `6.4.0` didn't have the issue
    */
    expect(true);
    } else {
    expect(consoleErrorSpy).not.toHaveBeenCalled();
    }

Details

As PatternFly doesn't (as v6.5.0) does not officially support React 19. A workaround had to be added to a unit test so it functions correctly.

Links

Tasks

  • Remove workaround

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    Status
    Accepted

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions