Add noVNC_setting_warn_before_close #2019
Conversation
Ability to to toggle the warning prompt before closing the tab or window introduced by 63c2c14 (PR novnc#2006). Closes novnc#2014
redneck-f25
force-pushed
the
feature/toggle-close-warning-prompt
branch
from
580b007 to
058f00f
Compare
|
Alright, now I've had time to test this after some delay... Codewise, I think it looks good! But there is one thing that bothers me. When trying different combinations with the two options (View only and Warn before close), things look a bit ambiguous. If view only is on, then Warn before close stays toggled in whatever position it was before view only was turned on. This can make it seem like the latter is on, and that you just can't turn it off without first disabling view only. So it's not obvious to users that there is a dependent behavior between the two options, especially that Warn before close gets implicitly disabled when View only is on. I therefore wonder if it wouldn't be better to make these two options entirely independent of each other. @redneck-f25 What do you think? |
|
@CendioOssman You had some opinions about this when we talked outside GitHub. Care to share? |
2 participants
Ability to to toggle the warning prompt before closing the tab or window introduced by 63c2c14 (PR #2006).
Closes #2014