-
Notifications
You must be signed in to change notification settings - Fork 111
Add vale linter to check for errors in text #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docs-novu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughIntroduces Vale writing configuration to the repository by creating a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.vale.ini (1)
1-19: Consider adding exclusion patterns to avoid false positives.The current configuration applies Vale rules broadly to all
.mdand.mdxfiles without exclusion patterns. Consider addingIgnoredScopesor other exclusion rules to prevent linting tool outputs, code blocks, configuration examples, or other non-prose content that might trigger false positives.For example:
[*.{md,mdx}] BasedOnStyles = Google, Novu, write-good +IgnoredScopes = code, code_block
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.gitignore(1 hunks).vale.ini(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Redirect rules - docs-novu
- GitHub Check: Header rules - docs-novu
- GitHub Check: Pages changed - docs-novu
- GitHub Check: Build and Lint
🔇 Additional comments (2)
.vale.ini (1)
18-19: Verify that the "Novu" style guide is available.The configuration references a "Novu" style guide alongside standard Vale packages (Google and write-good). Confirm that this custom style guide exists, is properly installed, or will be downloaded when Vale runs. If it's a project-specific style, consider documenting where/how it's obtained.
.gitignore (1)
32-33: LGTM!Good practice to exclude
.vale/stylesfrom version control, as this directory will contain downloaded style packages. Consistent with how other generated/downloaded artifacts are handled in the repository.
|
|
||
| # apply Google and Novu style guide rules to both Markdown (.md) and MDX (.mdx) files | ||
| [*.{md,mdx}] | ||
| BasedOnStyles = Google, Novu, write-good No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please share the link of Novu? I could not find here
https://vale.sh/explorer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jainpawan21, All rules are local for now. I am using Google and write-good rules for now to catch any errors before I commit them. So I need it merged. For now what I need is Google and write-good, while I work on the Novu style guide rules
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.