Improper select() error handling

[mitchellwrosen]

termbox/src/termbox.c

Lines 653 to 655 in bbb64e9

	int result = select(maxfd+1, &events, 0, 0, timeout);
	if (!result)
	return 0;

select returns -1 on error, which is never checked. This makes the function unresponsive to OS signals (EINTR), among other things.

[rofl0r]

i guess a patch/PR would be helpful.

[Darksider3]

Any reason why a simple if(result==SIG_ERR) return 0; didnt made it in yet, or shall i do that one? ^^

[jan-g]

SIG_ERR isn't the check.

if (result == -1 && errno == EINTR) ...