Commit 693419c
committed
fix(sdk): break runtime-bwrap → sdk → runtime-bwrap cycle that broke CI
Phase 2c (commit 2545e9e) added @computeragent/runtime-bwrap (+ runtime-local,
runtime-e2b, engine-claude-agent-sdk, identity-gitagentprotocol) to sdk's
devDependencies so the substrate-matrix tests could exercise them. But
runtime-bwrap already depends on sdk → cycle.
pnpm tolerates the cycle locally with a warning, ordering the builds in a way
that happens to work. CI parallelizes the cyclic packages and both fail with
TS2307 (can't resolve types of the not-yet-built sibling).
The matrix tests already use dynamic `await import(...)` inside makeSubstrate,
so the static devDeps were never load-bearing. The .test.ts file is excluded
from sdk's tsconfig (build + typecheck) — runtime resolution at test time
goes through workspace hoisting. Drop the cycle-creating devDeps.
Verified: pnpm -r build, pnpm -r typecheck, pnpm -r test all green; cyclic
workspace dependency warning gone; 349 passing / 57 skipped offline.1 parent 981a4f9 commit 693419c
2 files changed
Lines changed: 0 additions & 20 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | 30 | | |
36 | 31 | | |
37 | 32 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments