Skip to content

Commit 693419c

Browse files
committed
fix(sdk): break runtime-bwrap → sdk → runtime-bwrap cycle that broke CI
Phase 2c (commit 2545e9e) added @computeragent/runtime-bwrap (+ runtime-local, runtime-e2b, engine-claude-agent-sdk, identity-gitagentprotocol) to sdk's devDependencies so the substrate-matrix tests could exercise them. But runtime-bwrap already depends on sdk → cycle. pnpm tolerates the cycle locally with a warning, ordering the builds in a way that happens to work. CI parallelizes the cyclic packages and both fail with TS2307 (can't resolve types of the not-yet-built sibling). The matrix tests already use dynamic `await import(...)` inside makeSubstrate, so the static devDeps were never load-bearing. The .test.ts file is excluded from sdk's tsconfig (build + typecheck) — runtime resolution at test time goes through workspace hoisting. Drop the cycle-creating devDeps. Verified: pnpm -r build, pnpm -r typecheck, pnpm -r test all green; cyclic workspace dependency warning gone; 349 passing / 57 skipped offline.
1 parent 981a4f9 commit 693419c

2 files changed

Lines changed: 0 additions & 20 deletions

File tree

packages/sdk/package.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,6 @@
2727
},
2828
"devDependencies": {
2929
"@computeragent/harness-server": "workspace:*",
30-
"@computeragent/runtime-local": "workspace:*",
31-
"@computeragent/runtime-bwrap": "workspace:*",
32-
"@computeragent/runtime-e2b": "workspace:*",
33-
"@computeragent/engine-claude-agent-sdk": "workspace:*",
34-
"@computeragent/identity-gitagentprotocol": "workspace:*",
3530
"@computeragent/testing": "workspace:*",
3631
"@hono/node-server": "^1.13.0",
3732
"typescript": "^5.5.0",

pnpm-lock.yaml

Lines changed: 0 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)