Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Dec 15, 2025

null-checking this all the time is awkward

This was being used to detect whether in declarative configuration world or not, but I think instrumentations can still be split brained if they really want to by first looking for the specific declarative configuration they care about and falling back to system properties.

cc @zeitlinger

@trask trask force-pushed the get-instrumentation-config branch from ec0e1d7 to 95652e8 Compare December 15, 2025 23:25
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (40dbfa4) to head (95652e8).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7920   +/-   ##
=========================================
  Coverage     90.11%   90.11%           
- Complexity     7318     7319    +1     
=========================================
  Files           824      824           
  Lines         22027    22030    +3     
  Branches       2177     2177           
=========================================
+ Hits          19850    19853    +3     
  Misses         1500     1500           
  Partials        677      677           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@zeitlinger zeitlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea!

@trask
Copy link
Member Author

trask commented Dec 18, 2025

Looks like this is against spec language https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/api.md#get-instrumentation-config

If the .instrumentation node is not set, get instrumentation config MUST
return nil, null, undefined or another language-specific idiomatic pattern
denoting empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants