OCPBUGS-60426: Fix edit application via Deploy image internal registry doesn't select correct image stream

[vikram-raj]

Before:

before-edit-application.mov

After:

after-edit-application.mov

[openshift-ci-robot]

@vikram-raj: This pull request references Jira Issue OCPBUGS-60426, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Before:

before-edit-application.mov

After:

after-edit-application.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Adds a new constant RUNTIME_ICON_LABEL = 'app.openshift.io/runtime-icon' and updates label handling across components and tests to prefer this new label when deriving runtime icon values, with fallback to the existing runtime label and prior fallbacks preserved.

Changes

Cohort / File(s)	Change Summary
Constants frontend/packages/dev-console/src/const.ts	Adds exported constant RUNTIME_ICON_LABEL = 'app.openshift.io/runtime-icon'.
Edit application frontend/packages/dev-console/src/components/edit-application/edit-application-utils.ts, frontend/packages/dev-console/src/components/edit-application/__tests__/edit-application-data.ts	Import RUNTIME_ICON_LABEL; include the label in getDefaultLabels; prefer RUNTIME_ICON_LABEL when deriving runtimeIcon (fallback to RUNTIME_LABEL); test fixture updated to include the new label.
Import submission frontend/packages/dev-console/src/components/import/import-submit-utils.ts	Import and prefer RUNTIME_ICON_LABEL when deriving runtimeIcon from ImageStream metadata labels, falling back to RUNTIME_LABEL.
Resource label utilities & topology frontend/packages/dev-console/src/utils/resource-label-utils.ts, frontend/packages/topology/src/data-transforms/transform-utils.ts	Use RUNTIME_ICON_LABEL when constructing or reading resource labels and when resolving builder image icon; preserve existing fallback order and other fallbacks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify RUNTIME_ICON_LABEL is exported correctly from const.ts and all imports updated.
• Confirm consistent fallback order: RUNTIME_ICON_LABEL → RUNTIME_LABEL → other fallbacks.
• Run/inspect updated unit test fixture in __tests__/edit-application-data.ts to ensure expectations match new label usage.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[vikram-raj]

/jira refresh

[openshift-ci-robot]

@vikram-raj: This pull request references Jira Issue OCPBUGS-60426, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vikram-raj]

/cc @logonoff

[logonoff]

doesn't this mean we won't display any icons that were set prior to this bugfix?

[vikram-raj]

No, we will display the icon that were set prior to this.

[logonoff]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [logonoff,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vikram-raj]

/verified later @yapei

[openshift-ci-robot]

@vikram-raj: This PR has been marked to be verified later by @yapei.

In response to this:

/verified later @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[vikram-raj]

/verified later @yapei

[openshift-ci-robot]

@vikram-raj: This PR has been marked to be verified later by @yapei.

In response to this:

/verified later @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vikram-raj]

Resolved conflicts.

[vikram-raj]

/label acknowledge-critical-fixes-only

[vikram-raj]

/verified later @yapei

[openshift-ci-robot]

@vikram-raj: This PR has been marked to be verified later by @yapei.

In response to this:

/verified later @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

frontend/packages/dev-console/src/utils/resource-label-utils.ts (1)

32-34: Runtime icon label behavior looks correct; consider using shared constant for consistency

Using a dedicated app.openshift.io/runtime-icon key here correctly separates runtime metadata from the image stream runtime label and aligns with the PR’s intent. For consistency and easier future changes, consider importing and using the shared RUNTIME_ICON_LABEL constant from dev-console/src/const.ts instead of hardcoding the string.

-import { ResourcesKinds, Resources } from '../components/import/import-types';
+import { ResourcesKinds, Resources } from '../components/import/import-types';
+import { RUNTIME_ICON_LABEL } from '../const';
@@
-  if (runtimeIcon) {
-    labels['app.openshift.io/runtime-icon'] = runtimeIcon;
-  }
+  if (runtimeIcon) {
+    labels[RUNTIME_ICON_LABEL] = runtimeIcon;
+  }

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between e5267aa and 139d1df.

📒 Files selected for processing (6)

• frontend/packages/dev-console/src/components/edit-application/__tests__/edit-application-data.ts (1 hunks)
• frontend/packages/dev-console/src/components/edit-application/edit-application-utils.ts (3 hunks)
• frontend/packages/dev-console/src/components/import/import-submit-utils.ts (2 hunks)
• frontend/packages/dev-console/src/const.ts (1 hunks)
• frontend/packages/dev-console/src/utils/resource-label-utils.ts (1 hunks)
• frontend/packages/topology/src/data-transforms/transform-utils.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (5)

• frontend/packages/topology/src/data-transforms/transform-utils.ts
• frontend/packages/dev-console/src/components/edit-application/tests/edit-application-data.ts
• frontend/packages/dev-console/src/const.ts
• frontend/packages/dev-console/src/components/edit-application/edit-application-utils.ts
• frontend/packages/dev-console/src/components/import/import-submit-utils.ts

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• frontend/packages/dev-console/src/utils/resource-label-utils.ts

[vikram-raj]

/retest

[vikram-raj]

/retest

[openshift-ci]

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.