Skip to content

Commit b9547c8

Browse files
committed
comments correction
1 parent dfe772b commit b9547c8

2 files changed

Lines changed: 74 additions & 74 deletions

File tree

‎tests/feedback/test_4000_sync_profile.py‎

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ def profile(oci_credential, oci_compartment_id, test_env, cursor):
9797

9898
############################################### NEGATIVE FEEDBACK TESTS
9999
def test_4001(profile, cursor):
100-
"""Valid input: Test with valid prompt_spec, sql_id, response, and feedback_content."""
100+
"""Add negative feedback using SHOWSQL prompt_spec, response, and feedback_content."""
101101
prompt = PROMPT
102102
action = Action.SHOWSQL
103103
response = (
@@ -124,7 +124,7 @@ def test_4001(profile, cursor):
124124
assert response in show_prompt
125125

126126
def test_4002(profile, cursor):
127-
"""Valid input: Test with valid prompt_spec, sql_id, response, and feedback_content."""
127+
"""Add negative feedback using RUNSQL prompt_spec, response, and feedback_content."""
128128
prompt = PROMPT
129129
action = Action.RUNSQL
130130
response = (
@@ -151,7 +151,7 @@ def test_4002(profile, cursor):
151151
assert response in show_prompt
152152

153153
def test_4003(profile, cursor):
154-
"""Valid input: Test with valid prompt_spec, sql_id, response, and feedback_content."""
154+
"""Add negative feedback using EXPLAINSQL prompt_spec, response, and feedback_content."""
155155
prompt = PROMPT
156156
action = Action.EXPLAINSQL
157157
response = (
@@ -178,7 +178,7 @@ def test_4003(profile, cursor):
178178
assert response in show_prompt
179179

180180
def test_4004(profile, cursor):
181-
"""Valid input: Test with valid sql_id, response, and feedback_content."""
181+
"""Add negative feedback using SHOWSQL sql_id, response, and feedback_content."""
182182
sql_id = SHOWSQL_SQL_ID
183183
response = (
184184
"SELECT p4.name, g4.total_points FROM people p4 JOIN gymnast g4 "
@@ -203,7 +203,7 @@ def test_4004(profile, cursor):
203203
assert response in show_prompt
204204

205205
def test_4005(profile, cursor):
206-
"""Valid input: Test with valid sql_id, response, and feedback_content."""
206+
"""Add negative feedback using RUNSQL sql_id, response, and feedback_content."""
207207
sql_id = RUNSQL_SQL_ID
208208
response = (
209209
"SELECT p4.name, g4.total_points FROM people p4 JOIN gymnast g4 "
@@ -228,7 +228,7 @@ def test_4005(profile, cursor):
228228
assert response in show_prompt
229229

230230
def test_4006(profile, cursor):
231-
"""Valid input: Test with valid sql_id, response, and feedback_content."""
231+
"""Add negative feedback using EXPLAINSQL sql_id, response, and feedback_content."""
232232
sql_id = EXPLAINSQL_SQL_ID
233233
response = (
234234
"SELECT p4.name, g4.total_points FROM people p4 JOIN gymnast g4 "
@@ -253,7 +253,7 @@ def test_4006(profile, cursor):
253253
assert response in show_prompt
254254

255255
def test_4007(profile, cursor):
256-
"""Conflicting input: Test with both prompt_spec and sql_id for negative feedback."""
256+
"""Attempt negative feedback with both prompt_spec and sql_id."""
257257
prompt = PROMPT
258258
action = Action.SHOWSQL
259259
sql_id = SHOWSQL_SQL_ID
@@ -281,7 +281,7 @@ def test_4007(profile, cursor):
281281
logger.error("%s", str(exc_info.value).splitlines()[0])
282282

283283
def test_4008(profile, cursor):
284-
"""Missing required parameters: Test with missing response (for negative feedback)."""
284+
"""Attempt negative feedback without a response."""
285285
prompt = PROMPT
286286
action = Action.SHOWSQL
287287
sql_id = SHOWSQL_SQL_ID
@@ -301,7 +301,7 @@ def test_4008(profile, cursor):
301301
logger.error("%s", str(exc_info.value).splitlines()[0])
302302

303303
def test_4009(profile, cursor):
304-
"""Missing required parameters: Test with missing feedback_content (for negative feedback)."""
304+
"""Add negative feedback with sql_id and response but without feedback_content."""
305305
prompt = PROMPT
306306
action = Action.SHOWSQL
307307
sql_id = SHOWSQL_SQL_ID
@@ -325,7 +325,7 @@ def test_4009(profile, cursor):
325325
assert response in show_prompt
326326

327327
def test_4010(profile, cursor):
328-
"""Empty input: Test with empty strings or None values for prompt_spec."""
328+
"""Add negative feedback with prompt_spec=None and a valid sql_id."""
329329
sql_id = SHOWSQL_SQL_ID
330330
response = (
331331
"SELECT p6.name, g6.total_points FROM people p6 JOIN gymnast g6 "
@@ -351,7 +351,7 @@ def test_4010(profile, cursor):
351351
assert response in show_prompt
352352

353353
def test_4011(profile, cursor):
354-
"""Empty input: Test with empty strings or None values for sql_id."""
354+
"""Add negative feedback with sql_id=None and a valid prompt_spec."""
355355
prompt = PROMPT
356356
action = Action.SHOWSQL
357357
response = (
@@ -379,7 +379,7 @@ def test_4011(profile, cursor):
379379
assert response in show_prompt
380380

381381
def test_4012(profile, cursor):
382-
"""Empty input: Test with empty strings or None values for response."""
382+
"""Attempt negative feedback with response=None."""
383383
prompt = PROMPT
384384
action = Action.SHOWSQL
385385
sql_id = SHOWSQL_SQL_ID
@@ -400,7 +400,7 @@ def test_4012(profile, cursor):
400400
logger.error("%s", str(exc_info.value).splitlines()[0])
401401

402402
def test_4013(profile, cursor):
403-
"""Empty input: Test with empty strings or None values for feedback_content."""
403+
"""Add negative feedback with feedback_content=None using sql_id."""
404404
prompt = PROMPT
405405
action = Action.SHOWSQL
406406
sql_id = SHOWSQL_SQL_ID
@@ -426,7 +426,7 @@ def test_4013(profile, cursor):
426426

427427

428428
def test_4014(profile, cursor):
429-
"""Valid input: Test negative feedback with non-existent prompt."""
429+
"""Add negative feedback for a non-existent SHOWSQL prompt."""
430430
prompt = "Adding negative feedback with non existent prompt"
431431
action = Action.SHOWSQL
432432
response = (
@@ -454,7 +454,7 @@ def test_4014(profile, cursor):
454454

455455
############################################################## POSITIVE FEEDBACK TESTS
456456
def test_4015(profile, cursor):
457-
"""Valid input: Test with valid prompt_spec and sql_id."""
457+
"""Add positive feedback using SHOWSQL prompt_spec only."""
458458
prompt = PROMPT
459459
action = Action.SHOWSQL
460460
logger.info(
@@ -471,7 +471,7 @@ def test_4015(profile, cursor):
471471
assert "user_prompt" in show_prompt
472472

473473
def test_4016(profile, cursor):
474-
"""Valid input: Test with valid prompt_spec and sql_id for RUNSQL action."""
474+
"""Add positive feedback using RUNSQL prompt_spec only."""
475475
prompt = PROMPT
476476
action = Action.RUNSQL
477477
logger.info(
@@ -488,7 +488,7 @@ def test_4016(profile, cursor):
488488
assert "user_prompt" in show_prompt
489489

490490
def test_4017(profile, cursor):
491-
"""Valid input: Test with valid prompt_spec and sql_id for EXPLAINSQL action."""
491+
"""Add positive feedback using EXPLAINSQL prompt_spec only."""
492492
prompt = PROMPT
493493
action = Action.EXPLAINSQL
494494
logger.info(
@@ -505,7 +505,7 @@ def test_4017(profile, cursor):
505505
assert "user_prompt" in show_prompt
506506

507507
def test_4018(profile, cursor):
508-
"""Conflicting input: Test with both prompt_spec and sql_id for positive feedback."""
508+
"""Attempt positive feedback with both prompt_spec and sql_id."""
509509
prompt = PROMPT
510510
action = Action.SHOWSQL
511511
sql_id = SHOWSQL_SQL_ID
@@ -524,7 +524,7 @@ def test_4018(profile, cursor):
524524
logger.error("%s", str(exc_info.value).splitlines()[0])
525525

526526
def test_4019(profile, cursor):
527-
"""Valid input: Test with valid sql_id for positive feedback."""
527+
"""Add positive feedback using SHOWSQL sql_id only."""
528528
sql_id = SHOWSQL_SQL_ID
529529
logger.info("Adding positive feedback without prompt_spec using sql_id=%s", sql_id)
530530
profile.add_positive_feedback(sql_id=sql_id)
@@ -537,7 +537,7 @@ def test_4019(profile, cursor):
537537

538538

539539
def test_4020(profile, cursor):
540-
"""Valid input: Test with valid sql_id for positive feedback."""
540+
"""Add positive feedback using RUNSQL sql_id only."""
541541
sql_id = RUNSQL_SQL_ID
542542
logger.info("Adding positive feedback without prompt_spec using sql_id=%s", sql_id)
543543
profile.add_positive_feedback(sql_id=sql_id)
@@ -549,7 +549,7 @@ def test_4020(profile, cursor):
549549
assert "user_prompt" in show_prompt
550550

551551
def test_4021(profile, cursor):
552-
"""Valid input: Test with valid sql_id for positive feedback."""
552+
"""Add positive feedback using EXPLAINSQL sql_id only."""
553553
sql_id = EXPLAINSQL_SQL_ID
554554
logger.info("Adding positive feedback without prompt_spec using sql_id=%s", sql_id)
555555
profile.add_positive_feedback(sql_id=sql_id)
@@ -561,7 +561,7 @@ def test_4021(profile, cursor):
561561
assert "user_prompt" in show_prompt
562562

563563
def test_4022(profile, cursor):
564-
"""Empty input: Test with empty strings or None values for prompt_spec."""
564+
"""Add positive feedback with prompt_spec=None and a valid sql_id."""
565565
sql_id = SHOWSQL_SQL_ID
566566
logger.info("Adding positive feedback with prompt_spec=None sql_id=%s", sql_id)
567567
profile.add_positive_feedback(
@@ -576,7 +576,7 @@ def test_4022(profile, cursor):
576576
assert "user_prompt" in show_prompt
577577

578578
def test_4023(profile, cursor):
579-
"""Empty input: Test with empty strings or None values for sql_id."""
579+
"""Add positive feedback with sql_id=None and a valid prompt_spec."""
580580
prompt = PROMPT
581581
action = Action.SHOWSQL
582582
logger.info(
@@ -597,7 +597,7 @@ def test_4023(profile, cursor):
597597

598598

599599
def test_4024(profile, cursor):
600-
"""Valid input: Test positive feedback with non-existent prompt."""
600+
"""Attempt positive feedback for a non-existent SHOWSQL prompt."""
601601
prompt = "Adding positive feedback with non existent prompt"
602602
action = Action.SHOWSQL
603603
logger.info(
@@ -612,7 +612,7 @@ def test_4024(profile, cursor):
612612

613613
############################################################## DELETE FEEDBACK TESTS
614614
def test_4025(profile, cursor):
615-
"""Valid input: Test with valid prompt_spec."""
615+
"""Delete feedback by prompt_spec after adding positive SHOWSQL feedback."""
616616
prompt = PROMPT
617617
action = Action.SHOWSQL
618618
logger.info(
@@ -636,7 +636,7 @@ def test_4025(profile, cursor):
636636
assert show_prompt.count(PROMPT) == 1
637637

638638
def test_4026(profile, cursor):
639-
"""Valid input: Test delete feedback using sql_id."""
639+
"""Delete feedback by RUNSQL sql_id after adding negative feedback with sql_id."""
640640
sql_id = RUNSQL_SQL_ID
641641
response = (
642642
"SELECT p.name, g.total_points FROM people p JOIN gymnast g "
@@ -663,7 +663,7 @@ def test_4026(profile, cursor):
663663
assert show_prompt.count(PROMPT) == 1
664664

665665
def test_4027(profile, cursor):
666-
"""Valid input: Test delete feedback with valid prompt_spec."""
666+
"""Delete feedback by prompt_spec after adding positive EXPLAINSQL feedback."""
667667
prompt = PROMPT
668668
action = Action.EXPLAINSQL
669669
logger.info(
@@ -686,7 +686,7 @@ def test_4027(profile, cursor):
686686
assert show_prompt.count(PROMPT) == 1
687687

688688
def test_4028(profile, cursor):
689-
"""Valid input: Test delete feedback by sql_id after negative feedback."""
689+
"""Delete SHOWSQL feedback by sql_id after adding negative prompt-based feedback."""
690690
prompt = PROMPT
691691
action = Action.SHOWSQL
692692
sql_id = SHOWSQL_SQL_ID
@@ -717,10 +717,10 @@ def test_4028(profile, cursor):
717717

718718

719719
def test_4029(profile, cursor):
720-
"""Valid input: Test delete feedback by sql_id after negative feedback."""
720+
"""Delete RUNSQL feedback by sql_id after adding negative prompt-based feedback."""
721721
prompt = PROMPT
722-
action = Action.SHOWSQL
723-
sql_id = SHOWSQL_SQL_ID
722+
action = Action.RUNSQL
723+
sql_id = RUNSQL_SQL_ID
724724
response = (
725725
"SELECT p.name, g.total_points FROM people p JOIN gymnast g "
726726
"ON p.id = g.id ORDER BY g.total_points DESC"
@@ -747,10 +747,10 @@ def test_4029(profile, cursor):
747747
assert show_prompt.count(PROMPT) == 1
748748

749749
def test_4030(profile, cursor):
750-
"""Valid input: Test delete feedback by sql_id after negative feedback."""
750+
"""Delete EXPLAINSQL feedback by sql_id after adding negative prompt-based feedback."""
751751
prompt = PROMPT
752-
action = Action.SHOWSQL
753-
sql_id = SHOWSQL_SQL_ID
752+
action = Action.EXPLAINSQL
753+
sql_id = EXPLAINSQL_SQL_ID
754754
response = (
755755
"SELECT p.name, g.total_points FROM people p JOIN gymnast g "
756756
"ON p.id = g.id ORDER BY g.total_points DESC"
@@ -778,7 +778,7 @@ def test_4030(profile, cursor):
778778

779779

780780
def test_4031(profile, cursor):
781-
"""Valid input: Test delete feedback with sql_id=None."""
781+
"""Delete feedback with sql_id=None and a valid prompt_spec."""
782782
prompt = PROMPT
783783
action = Action.SHOWSQL
784784
sql_id = SHOWSQL_SQL_ID
@@ -808,7 +808,7 @@ def test_4031(profile, cursor):
808808

809809

810810
def test_4032(profile, cursor):
811-
"""Valid input: Test delete feedback with prompt_spec=None."""
811+
"""Delete feedback with prompt_spec=None and a valid sql_id."""
812812
prompt = PROMPT
813813
action = Action.SHOWSQL
814814
sql_id = SHOWSQL_SQL_ID
@@ -832,7 +832,7 @@ def test_4032(profile, cursor):
832832
assert show_prompt.count(PROMPT) == 1
833833

834834
def test_4033(profile, cursor):
835-
"""Conflicting input: Test delete feedback with both prompt_spec and sql_id."""
835+
"""Attempt delete_feedback with both prompt_spec and sql_id."""
836836
prompt = PROMPT
837837
action = Action.SHOWSQL
838838
sql_id = SHOWSQL_SQL_ID

0 commit comments

Comments
 (0)