Skip to content

Removing is_bidirectional and corr from ENOT #661

@marcocuturi

Description

@marcocuturi

Hi @nazarblch

As part of a more general refactoring with @michalk8 , in #660, we're removing the corr option in dual potentials. This is no longer needed as it can be handled directly when instantiating the dual callable functions for a SqEuclidean cost, saving the trouble on adding back norms when computing W2 distance, etc

While looking over ENOT, we noticed that we cannot run the notebook using bidirectional=False so we're removing that bit as well (we're not sure it's mentioned in the experiments of the paper either).

If you happen to have the time, it would be also great if you could add simple tests for ENOT, thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions