-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Test] Persist setOrder array between turns; remove duplicate calls in test cases
#6781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Bertie690
wants to merge
14
commits into
pagefaultgames:beta
Choose a base branch
from
Bertie690:duplicate-set-turn-order
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Test] Persist setOrder array between turns; remove duplicate calls in test cases
#6781
Bertie690
wants to merge
14
commits into
pagefaultgames:beta
from
Bertie690:duplicate-set-turn-order
+155
−160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setTurnOrder within the same test caseGameManager.setTurnOrder within the same test case
8cb5562 to
2c6c7a0
Compare
GameManager.setTurnOrder within the same test casesetOrder array between turns; remove duplicate calls in test cases
fdf0a40 to
35ac6a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLOCKED BY #6779
What are the changes the user will see?
N/A
Why am I making these changes?
As I discussed in #6779, the
setOrderarray really should default to sticking around between turns.What are the changes from a developer perspective?
Removed code to clear
setTurnOrderupon clearing phase queuesRemoved duplicate calls to
setTurnOrderin the same test cases with the exact same argumentsREGEX:
(?<foo>.*setTurnOrder\(.*?\);\n)((?:(?!\}\);).|\n)+)\k<foo>=>$1$2Screenshots/Videos
N/A
How to test the changes?
run the existing tests, should change next to nothing (or literally nothing after #6779 is merged)
Checklist
betaas my base branchpnpm test:silent)