Skip to content

Conversation

@Bertie690
Copy link
Contributor

@Bertie690 Bertie690 commented Nov 15, 2025

BLOCKED BY #6779

What are the changes the user will see?

N/A

Why am I making these changes?

As I discussed in #6779, the setOrder array really should default to sticking around between turns.

What are the changes from a developer perspective?

Removed code to clear setTurnOrder upon clearing phase queues

Removed duplicate calls to setTurnOrder in the same test cases with the exact same arguments

REGEX:
(?<foo>.*setTurnOrder\(.*?\);\n)((?:(?!\}\);).|\n)+)\k<foo> => $1$2

Screenshots/Videos

N/A

How to test the changes?

run the existing tests, should change next to nothing (or literally nothing after #6779 is merged)

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (pnpm test:silent)

@Bertie690 Bertie690 requested a review from a team as a code owner November 15, 2025 17:41
@Bertie690 Bertie690 changed the title [Test] Remove duplicate calls to setTurnOrder within the same test case [Test] Remove duplicate calls to GameManager.setTurnOrder within the same test case Nov 15, 2025
@Bertie690 Bertie690 force-pushed the duplicate-set-turn-order branch from 8cb5562 to 2c6c7a0 Compare November 15, 2025 18:13
@Bertie690 Bertie690 marked this pull request as draft November 15, 2025 18:15
@Madmadness65 Madmadness65 added the Tests Automated tests related label Nov 15, 2025
@Bertie690 Bertie690 changed the title [Test] Remove duplicate calls to GameManager.setTurnOrder within the same test case [Test] Persist setOrder array between turns; remove duplicate calls in test cases Nov 15, 2025
@Bertie690 Bertie690 force-pushed the duplicate-set-turn-order branch from fdf0a40 to 35ac6a7 Compare November 30, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tests Automated tests related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants