Skip to content

Conversation

@Bertie690
Copy link
Contributor

What are the changes the user will see?

N/A

Why am I making these changes?

I noticed toHaveBattlerTag was distributing over B.

This was causing it to show all properties on all battler tags if left unchecked.

What are the changes from a developer perspective?

Made type non distributive

applied similar caching to toHaveArenaTag

Screenshots/Videos

N/A

How to test the changes?

try using the matchers with an empty object:

expect(enemy).toHaveArenaTag({});
//                            ^ ctrl-click here, should only get base class props

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (pnpm test:silent)

@Bertie690 Bertie690 requested a review from a team as a code owner December 3, 2025 19:26
@Madmadness65 Madmadness65 added the Tests Automated tests related label Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tests Automated tests related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants