Skip to content

Post to slack webhook should be done on remote app server #60

@halida

Description

@halida

Slack webhook url is configured in deploy.rb now, but it may cause problems:

  • If slack webhook url is saved in git repo, it may cause security leak for slack.
  • If slack webhook url is saved under local config file, every developer should set webhook url on their local config, which may lead to inconsistent: If webhook url is updated, and one of the developer didn't update it, His deploy operation cannot notify slack.

So I think the good solution is like this:

  • Post to slack webhook url should be done on remote app server
  • Remote app server should save webhook url on an config file

Example:

It may changes a lot and make things complicate, but I think it is the good practice.

Metadata

Metadata

Assignees

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions