Apply fixed Coderabbitai review.

Author: terabytesoftw

resources/assets/dist/js/toolbar.min.js

@@ -88,6 +88,29 @@ export function YiiDebugToolbar() {
   self.boundPointerUp = self.onPointerUp.bind(self);
   self.boundHostThemeRefresh = self.refreshHostThemeControl.bind(self);
   self.boundThemeRefresh = self.refreshTheme.bind(self);
+  /**
+   * A pointer landing anywhere but the menu dismisses it. Built here with the
+   * other bound handlers so the registration can follow the element lifecycle:
+   * `connectedCallback()` attaches it to the document and
+   * `disconnectedCallback()` detaches it again.
+   */
+  self.boundExtensionsPointerDown = function (event) {
+    if (!self.extensionsOpen) {
+      return;
+    }
+
+    /**
+     * Listening on the document means `event.target` is retargeted to the
+     * host element; the composed path still carries the real one.
+     */
+    var path =
+      typeof event.composedPath === "function" ? event.composedPath() : [];
+    var target = path.length > 0 ? path[0] : event.target;
+
+    if (!isInsideExtensions(target, closest)) {
+      self.closeExtensions(false);
+    }
+  };
   self.theme = null;
   self.themeObserver = null;
   self.themeRefreshTimer = null;
@@ -107,6 +130,12 @@ YiiDebugToolbar.prototype.connectedCallback = function () {
     toolbars.push(this);
   }
 
+  document.addEventListener(
+    "pointerdown",
+    this.boundExtensionsPointerDown,
+    false,
+  );
+
   resetHostThemeControlCache();
   this.ownsTheme = !hostHasThemeControl();
   this.refreshTheme();
@@ -163,6 +192,11 @@ YiiDebugToolbar.prototype.disconnectedCallback = function () {
   this.resizing = false;
   document.removeEventListener("pointermove", this.boundPointerMove, false);
   document.removeEventListener("pointerup", this.boundPointerUp, false);
+  document.removeEventListener(
+    "pointerdown",
+    this.boundExtensionsPointerDown,
+    false,
+  );
 };
 
 YiiDebugToolbar.prototype.setAjaxRequests = function (requests) {
@@ -877,7 +911,7 @@ YiiDebugToolbar.prototype.renderExtensions = function (extensions) {
     (open ? " is-open" : "") +
     '"><button type="button" class="panel extensions-toggle' +
     (active ? " panel-active" : "") +
-    '" aria-haspopup="true" aria-expanded="' +
+    '" aria-expanded="' +
     (open ? "true" : "false") +
     '" aria-controls="extensions-menu" title="Extensions">' +
     this.iconHtml("dots", "panel-icon") +
@@ -1227,37 +1261,6 @@ YiiDebugToolbar.prototype.bindDelegatedEvents = function () {
     event.stopPropagation();
     self.closeDrawer();
   });
-
-  /**
-   * A pointer landing anywhere but the menu dismisses it. Registered once per
-   * element — `ensureShadowSkeleton()` binds the delegates a single time, and
-   * the guard keeps a re-entry from stacking duplicates.
-   */
-  if (!this.boundExtensionsPointerDown) {
-    this.boundExtensionsPointerDown = function (event) {
-      if (!self.extensionsOpen) {
-        return;
-      }
-
-      /**
-       * Listening on the document means `event.target` is retargeted to the
-       * host element; the composed path still carries the real one.
-       */
-      var path =
-        typeof event.composedPath === "function" ? event.composedPath() : [];
-      var target = path.length > 0 ? path[0] : event.target;
-
-      if (!isInsideExtensions(target, closest)) {
-        self.closeExtensions(false);
-      }
-    };
-
-    document.addEventListener(
-      "pointerdown",
-      this.boundExtensionsPointerDown,
-      false,
-    );
-  }
 };
 
 /**

resources/src/toolbar/element.js

@@ -7,14 +7,42 @@
 use PHPForge\Debug\Theme\Css;
 use UIAwesome\Html\Phrasing\{Span, Strong};
 
+use function preg_replace;
+use function sha1;
 use function strrpos;
+use function strtolower;
 use function substr;
+use function trim;
 
 /**
- * Splits a fully-qualified class name into its short name and namespace prefix.
+ * Derives the presentation forms of a fully-qualified class name: short name, namespace prefix, two-tone label, and
+ * fragment anchor.
  */
 final class Fqcn
 {
+    /**
+     * Returns a URL-safe fragment id for a fully-qualified class name, stable across spellings and free of collisions.
+     *
+     * The name is lowercased first because PHP resolves class names case-insensitively, so every spelling of one class
+     * must share one anchor. The readable slug collapses each run of characters outside `a-z0-9` into a single `-`,
+     * which on its own is not injective (`app\A_B` and `app\A__b` both flatten to `app-a-b`), so the first 8
+     * hexadecimal characters of the `sha1` of the lowercased name are appended to keep distinct classes apart; that
+     * digest identifies a DOM id and is never used as a security primitive. A name made only of separators leaves no
+     * slug and returns the digest alone.
+     *
+     * @param string $fqcn Fully-qualified class name.
+     *
+     * @return string URL-safe fragment id.
+     */
+    public static function anchor(string $fqcn): string
+    {
+        $lowercased = strtolower($fqcn);
+        $slug = trim((string) preg_replace('/[^a-z0-9]+/', '-', $lowercased), '-');
+        $digest = substr(sha1($lowercased), 0, 8);
+
+        return $slug === '' ? $digest : "{$slug}-{$digest}";
+    }
+
     /**
      * Returns the namespace prefix (everything before the last `\`, without trailing separator), or `''` when none is
      * present.

src/Helper/Fqcn.php

@@ -5,7 +5,7 @@
 namespace PHPForge\Debug\Panel\Asset;
 
 use PHPForge\Debug\{ColumnStyle, Panel, PanelView, Tone};
-use PHPForge\Debug\Helper\{Fqcn, Text};
+use PHPForge\Debug\Helper\Fqcn;
 use PHPForge\Debug\Presenter\{FileEntry, LinkInline};
 
 use function array_map;
@@ -168,7 +168,7 @@ private static function card(PanelView $view, AssetBundleRow $bundle): PanelView
         $namespace = Fqcn::namespacePart($bundle->name);
 
         return $view->card(
-            Text::camel2id($bundle->name),
+            Fqcn::anchor($bundle->name),
             AssetMessage::ID->value,
             Fqcn::shortName($bundle->name),
             $namespace === '' ? '' : "{$namespace}\\",
@@ -342,7 +342,7 @@ private static function wiring(AssetBundleRow $bundle): PanelView|null
             ...array_map(
                 static fn(string $depend): LinkInline => PanelView::link(
                     Fqcn::shortName($depend),
-                    '#' . Text::camel2id($depend),
+                    '#' . Fqcn::anchor($depend),
                 ),
                 $bundle->depends,
             ),

src/Panel/Asset/AssetPanel.php

@@ -9,13 +9,73 @@
 use PHPUnit\Framework\TestCase;
 
 /**
- * Unit tests for {@see Fqcn} covering the shared two-tone label markup: namespace/short-name splitting, method-suffix
- * handling, the plain-value and empty-value fallbacks, and the `title` attribute.
+ * Unit tests for {@see Fqcn} covering the fragment anchor and the shared two-tone label markup: namespace/short-name
+ * splitting, method-suffix handling, the plain-value and empty-value fallbacks, and the `title` attribute.
  */
 #[Group('helpers')]
 #[Group('fqcn')]
 final class FqcnTest extends TestCase
 {
+    public function testAnchorDistinguishesNamesThatShareASlug(): void
+    {
+        self::assertSame(
+            'app-a-b-e8f13edb',
+            Fqcn::anchor('app\\A_B'),
+            'Each separator run must collapse to one dash.',
+        );
+        self::assertSame(
+            'app-a-b-91495c5b',
+            Fqcn::anchor('app\\A__b'),
+            'A shared slug must still carry its own digest.',
+        );
+        self::assertNotSame(
+            Fqcn::anchor('app\\A_B'),
+            Fqcn::anchor('app\\A__b'),
+            'Distinct classes must never share an anchor.',
+        );
+    }
+
+    public function testAnchorDropsTheNamespaceForAGlobalClass(): void
+    {
+        self::assertSame(
+            'globalasset-762af4c5',
+            Fqcn::anchor('GlobalAsset'),
+            'A class outside any namespace must slug alone.',
+        );
+    }
+
+    public function testAnchorReturnsTheDigestAloneForASeparatorOnlyName(): void
+    {
+        self::assertSame(
+            'ebf29a14',
+            Fqcn::anchor('\\_\\'),
+            'An empty slug must leave the digest unprefixed.',
+        );
+    }
+
+    public function testAnchorSharesOneValueAcrossCaseVariantsOfOneClass(): void
+    {
+        self::assertSame(
+            'app-service-mailer-c39fd4a3',
+            Fqcn::anchor('App\\Service\\Mailer'),
+            'The anchor must be lowercase end to end.',
+        );
+        self::assertSame(
+            Fqcn::anchor('App\\Service\\Mailer'),
+            Fqcn::anchor('app\\service\\mailer'),
+            'Case variants of one class must share an anchor.',
+        );
+    }
+
+    public function testAnchorSlugsANamespacedClassAndAppendsItsDigest(): void
+    {
+        self::assertSame(
+            'app-assets-appasset-3c6a8113',
+            Fqcn::anchor('app\\assets\\AppAsset'),
+            'Separators must give way to a dash-joined slug.',
+        );
+    }
+
     public function testNamespacePartReturnsPrefixOrEmptyString(): void
     {
         self::assertSame(

tests/Helper/FqcnTest.php

@@ -53,7 +53,7 @@ public function testBundleWithoutFilesWiringOrDependenciesRendersABodylessCard()
         );
 
         self::assertSame(
-            'app\\assets\\-empty-asset',
+            'app-assets-emptyasset-e3777dff',
             $card->id,
             'Anchor must survive an empty capture.',
         );
@@ -125,7 +125,7 @@ public function testEmptyCaptureDeactivatesThePanelAndExplainsTheMissingBundles(
         );
     }
 
-    public function testGlobalNamespaceBundleDropsTheSubtitleAndKeepsItsBareAnchor(): void
+    public function testGlobalNamespaceBundleDropsTheSubtitleAndAnchorsOnItsBareClassName(): void
     {
         $card = self::card(
             self::blockAt(
@@ -135,9 +135,9 @@ public function testGlobalNamespaceBundleDropsTheSubtitleAndKeepsItsBareAnchor()
         );
 
         self::assertSame(
-            'global-asset',
+            'globalasset-762af4c5',
             $card->id,
-            'Anchor must drop to the bare class name.',
+            'Anchor must slug the class name alone.',
         );
         self::assertSame(
             'GlobalAsset',
@@ -179,12 +179,23 @@ public function testRegisteredBundlesProduceTheirCardsWithFilesAndWiringColumns(
                 self::bundle(['depends' => ['yii\\web\\YiiAsset', 'yii\\web\\JqueryAsset']]),
                 self::bundle(
                     [
-                        'name' => 'app\\assets\\SecondAsset',
+                        'name' => 'yii\\web\\YiiAsset',
                         'sourcePath' => '',
                         'basePath' => '',
                         'baseUrl' => '',
                         'css' => [],
-                        'js' => ['second.js'],
+                        'js' => ['yii.js'],
+                        'depends' => [],
+                    ],
+                ),
+                self::bundle(
+                    [
+                        'name' => 'yii\\web\\JqueryAsset',
+                        'sourcePath' => '',
+                        'basePath' => '',
+                        'baseUrl' => '',
+                        'css' => [],
+                        'js' => ['jquery.js'],
                         'depends' => [],
                     ],
                 ),
@@ -197,24 +208,24 @@ public function testRegisteredBundlesProduceTheirCardsWithFilesAndWiringColumns(
         );
         self::assertEquals(
             [
-                new StatEntry('asset', 'bundles', '2', Tone::MUTED),
+                new StatEntry('asset', 'bundles', '3', Tone::MUTED),
                 new StatEntry('brand-css3', 'css', '1', Tone::INFO),
-                new StatEntry('brand-javascript', 'js', '3', Tone::WARNING),
+                new StatEntry('brand-javascript', 'js', '4', Tone::WARNING),
                 new StatEntry('link', 'links', '2', Tone::SUCCESS),
             ],
             self::stats(self::blockAt($view, 0))->stats,
             'The aggregate tiles must total every bundle.',
         );
         self::assertEquals(
-            [new ToolbarMetric('Bundles', '2')],
+            [new ToolbarMetric('Bundles', '3')],
             $view->toolbarMetrics(),
             'The toolbar must report the bundle count.',
         );
 
         $card = self::card(self::blockAt($view, 1));
 
         self::assertSame(
-            'app\\assets\\-app-asset',
+            'app-assets-appasset-3c6a8113',
             $card->id,
             'Anchor must derive from the bundle class.',
         );
@@ -288,30 +299,36 @@ public function testRegisteredBundlesProduceTheirCardsWithFilesAndWiringColumns(
             $depends->label,
             'The strip must count what it lists.',
         );
+
+        $yii = self::card(self::blockAt($view, 2));
+        $jquery = self::card(self::blockAt($view, 3));
+
+        self::assertSame(
+            ['yii-web-yiiasset-7afeb318', 'yii-web-jqueryasset-2772d8b9'],
+            [$yii->id, $jquery->id],
+            'Every dependency must own a URL-safe card anchor.',
+        );
         self::assertEquals(
             [
-                new LinkInline('YiiAsset', '#yii\\web\\-yii-asset', false),
-                new LinkInline('JqueryAsset', '#yii\\web\\-jquery-asset', false),
+                new LinkInline('YiiAsset', "#{$yii->id}", false),
+                new LinkInline('JqueryAsset', "#{$jquery->id}", false),
             ],
             $depends->links,
             'Each dependency must point at the anchor of its own card.',
         );
-
-        $second = self::card(self::blockAt($view, 2));
-
         self::assertEquals(
             [new BadgeInline('1 js', Tone::WARNING)],
-            $second->meta,
+            $yii->meta,
             'An absent kind must leave no chip behind.',
         );
         self::assertCount(
             1,
-            $second->columns,
+            $yii->columns,
             'A bundle that publishes nothing must keep only its files.',
         );
         self::assertEquals(
-            [new FileEntry('.js', 'second.js', Tone::WARNING)],
-            self::files(self::columnBlockAt(self::column($second, 0), 0))->files,
+            [new FileEntry('.js', 'yii.js', Tone::WARNING)],
+            self::files(self::columnBlockAt(self::column($yii, 0), 0))->files,
             'Scripts alone must still fill the first list.',
         );
     }

tests/Panel/Asset/AssetPanelTest.php

@@ -118,7 +118,7 @@ public function testAuthenticatedIdentityDescribesItsHeroAndAttributeSections():
             new TextInline('secret-auth-key', TextStyle::PREVIEW),
             self::fields(self::overview(self::blockAt($view, 4)))['Security key']
                 ?? self::fail('The security section must keep the auth key row.'),
-            'A sensitive attribute must stay clamped behind the standard expand control.',
+            'The redacted key must carry the preview style.',
         );
         self::assertSame(
             date('M j, Y · H:i', self::TIME),