cloud: Premium db auditing doc improvement - #23537
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe audit logging documentation now covers logging configuration, redaction, filter-rule creation, selectable audit events, event classes, and SQL user pattern matching. ChangesAudit logging documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🔵 Low · up to This change improves Premium database-auditing documentation, but it still has bounded correctness risks around rendered user-pattern examples, the TiDB version requirement for time-based rotation, and the syntax and semantics of audit filters; these should receive explicit owner follow-up before or with merge. Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 09a9e6a4-b01c-4f31-968e-4e62bbed50c7
📒 Files selected for processing (1)
tidb-cloud/premium/tidb-cloud-auditing-premium.md
Included review availability: Your plan includes up to 4 reviews per rolling hour; 3 remain after this review.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tidb-cloud/premium/tidb-cloud-auditing-premium.md (1)
254-271: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winDocument the actual rotation controls.
This section has no flush-size or flush-interval options. Use rotation size in MiB and rotation interval in minutes, and document the Premium-specific defaults and valid ranges. The existing step already states that Save and Enable applies the settings. Do not describe these controls as flush settings.
Source: Path instructions
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4ca8af3e-eed4-4fb8-b1fa-58aaaa755dbf
📒 Files selected for processing (1)
tidb-cloud/premium/tidb-cloud-auditing-premium.md
Included review availability: Your plan includes up to 4 reviews per rolling hour; 2 remain after this review.
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tidb-cloud/premium/tidb-cloud-auditing-premium.md (1)
254-270: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick winDocument the TiDB version requirement for time-based rotation.
The Premium page states that time-based rotation is always available. Add the existing requirement that this option applies only to TiDB v8.5.2 or later.
Suggested replacement
You can rotate audit log files based on either file size or time interval. When either condition is met, TiDB Cloud generates a new audit log file. > **Note:** > > Log file rotation based on time interval only applies to TiDB v8.5.2 or later. If the TiDB version of your TiDB Cloud Dedicated cluster is earlier than v8.5.2, you can only rotate audit log files based on file size.Source: Path instructions
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: b36a37be-2797-444d-92fe-ad323a13004f
📒 Files selected for processing (2)
tidb-cloud/premium/tidb-cloud-auditing-premium.mdtidb-cloud/tidb-cloud-auditing.md
Included review availability: Your plan includes up to 4 reviews per rolling hour; 3 remain after this review.
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
First-time contributors' checklist
What is changed, added or deleted? (Required)
The premium db auditing has two mistake, fix it in this PR.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
%matches zero or more characters and_matches exactly one character in SQL user filters.