Skip to content

Deps on go_repo() are not added to the generated cgo_library() #303

Description

@sfirmery

I'm trying to build a static go_binary() that use a go library (github.com/GRbit/go-pcre) that use cgo.

I put the c_library() of libpcre as a dependency of the go_repo(), patched go_repo() to use it instead relying on pkg-config, but the generated BUILD file in this subrepo did not contains the dependency in the cgo_library() and make it fail with a missing header.

I managed to make it works by manually add the c_library() dependency to the cgo_library() in the BUILD file in plz-out/subrepos/third_party/go/github.com_GRbit_go-pcre/BUILD.

Can please_go add this dependency automatically?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions