Hiding fields depending on category does not work #847

Activity

1. DaviidMM commented on Jan 13, 2025

   

   DaviidMM

   on Jan 13, 2025

   Author

   More actions

   Still having this issue...
2. akstis-typer commented on Apr 10, 2025

   

   akstis-typer

   on Apr 10, 2025

   Last edited by akstis-typer

   More actions

   I was having the same issue. And I, so called "fixed" it.
   In field.class.php I added || strpos($current_url, 'tracking.injector.php') !== false to the if statements.
   Because, when you start using ticket form - your address is not 'helpdesk.public.php' anymore it's 'tracking.injector.php'

   if (strpos($current_url, 'helpdesk.public.php') !== false || strpos($current_url, 'tracking.injector.php') !== false) {
               echo "<div id='{$html_id}' class='card-body row mx-0' style='border-top:0'>";
               echo "<div class='offset-md-1 col-md-8 col-xxl-6'>";
               $field_options = [
                   'label_class' => 'col-lg-3',
                   'input_class' => 'col-lg-9',
               ];
           } else {
               echo "<div id='{$html_id}'>";
           }
           $display_condition = new PluginFieldsContainerDisplayCondition();
   
           if ($display_condition->computeDisplayContainer($item, $c_id))
           {
               self::showDomContainer(
                   $c_id,
                   $item,
                   $type,
                   $subtype,
                   $field_options ?? [],
               );
           }
           if (strpos($current_url, 'helpdesk.public.php') !== false || strpos($current_url, 'tracking.injector.php') !== false) {
               echo '</div>';
           }
   

   This will fix the alignment issue.

   Next, I edited showForTab function like so

   public static function showForTab($params)
       {
           $item = $params['item'];
   
           if($item->fields['type'] == "")
           {
               $item->fields['type'] = $params['options']['type'];
           }
           if($item->fields['itilcategories_id'] == "")
           {
               $item->fields['itilcategories_id'] = $params['options']['itilcategories_id'];
           }
   

   There, if we don't have type in $item or we don't have itilcategories_id- we got them from $params options.

   This will fix all issues with containers, and you will be able to show or hide them according to your conditions.
   If there is a better way to fix this issue - tell me.
3. stonebuzz commented on Apr 10, 2025

   

   stonebuzz

   on Apr 10, 2025

   Contributor

   More actions

   Hi @akstis-typer

   can you propose a PR ?

   👍React with 👍1Reacted by NikolayNK
4. DaviidMM commented on Apr 10, 2025

   

   DaviidMM

   on Apr 10, 2025

   Author

   More actions

   Hi! I've tried the code, but it didn’t work as expected in my case. I had to move a few lines of your code further down in fields.inc.php to make it work properly.

    public static function showForTab($params)
       {
           $item = $params['item'];
   
           $functions = array_column(debug_backtrace(), 'function');
           ...
           $display_condition = new PluginFieldsContainerDisplayCondition();
   
           // @akstis-typer code starts here ------
           if($item->fields['type'] == "")
           {
               $item->fields['type'] = $params['options']['type'];
           }
           if($item->fields['itilcategories_id'] == "")
           {
               $item->fields['itilcategories_id'] = $params['options']['itilcategories_id'];
           }
           // @akstis-typer code ends here ------
   
           if ($display_condition->computeDisplayContainer($item, $c_id)) {
           ...

   The issue seemed to be related to this part of the code:

   if ($item->isEntityAssign()) {
       $current_entity = $item->getEntityID();
       if (!in_array($current_entity, $entities)) {
           return;
       }
   }

   I’m not entirely sure what this block was doing, but in my case it was preventing the code from working as expected — the values assigned by @akstis-typer snippet were overriden once again to empty values.

   Hope this helps!

   😄React with 😄1Reacted by NikolayNK

   🎉React with 🎉1Reacted by Izaac Menezes
5. github-actions commented on May 21, 2025

   

   github-actionsBot

   on May 21, 2025 – with GitHub Actions

   More actions

   There has been no activity on this issue for some time and therefore it is considered stale and will be closed automatically in 10 days.

   If this issue is related to a bug, please try to reproduce on latest release. If the problem persist, feel free to add a comment to revive this issue.
   If it is related to a new feature, please open a topic to discuss with community about this enhancement on suggestion website.

   You may also consider taking a subscription to get professionnal support or contact GLPI editor team directly.
6. github-actions

   added

   Stale

   on May 21, 2025
7. trasher commented on May 23, 2025

   

   trasher

   on May 23, 2025

   Contributor

   More actions

   @DaviidMM please try fix proposed in #942
8. trasher

   added

   bug

   and removed

   Stale

   on May 23, 2025