From b9cb1b4eed269b7fbcf516ce5f1ed3be99389d47 Mon Sep 17 00:00:00 2001 From: "Sean T. Allen" Date: Thu, 11 Jun 2026 21:28:44 -0400 Subject: [PATCH] Stop passing the removed `--link-ldcmd` ponyc option MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ponyc removed the `--linker` and `--link-ldcmd` command line options (ponylang/ponyc#5452); embedded LLD is now the only linker. Our Linux release builds passed `linker=bfd`, which the Makefile turned into `--link-ldcmd=bfd`, so they now fail with `Unrecognised option`. That flag already had no effect on embedded LLD, so these static binaries were already being linked by it — dropping `linker=bfd` and the Makefile option that produced the flag changes nothing about the output. --- .ci-scripts/release/arm64-unknown-linux-nightly.bash | 2 +- .ci-scripts/release/arm64-unknown-linux-release.bash | 2 +- .ci-scripts/release/x86-64-unknown-linux-nightly.bash | 2 +- .ci-scripts/release/x86-64-unknown-linux-release.bash | 2 +- Makefile | 5 ----- 5 files changed, 4 insertions(+), 9 deletions(-) diff --git a/.ci-scripts/release/arm64-unknown-linux-nightly.bash b/.ci-scripts/release/arm64-unknown-linux-nightly.bash index 9c6b763..7bf639a 100755 --- a/.ci-scripts/release/arm64-unknown-linux-nightly.bash +++ b/.ci-scripts/release/arm64-unknown-linux-nightly.bash @@ -94,7 +94,7 @@ ASSET_DESCRIPTION="https://github.com/${GITHUB_REPOSITORY}" # Build application installation echo -e "\e[34mBuilding ${APPLICATION_NAME}...\e[0m" make install prefix="${BUILD_DIR}" arch=${CPU} \ - version="${APPLICATION_VERSION}" static=true linker=bfd + version="${APPLICATION_VERSION}" static=true # Package it all up echo -e "\e[34mCreating .tar.gz of ${APPLICATION_NAME}...\e[0m" diff --git a/.ci-scripts/release/arm64-unknown-linux-release.bash b/.ci-scripts/release/arm64-unknown-linux-release.bash index 5f5831d..66765b5 100755 --- a/.ci-scripts/release/arm64-unknown-linux-release.bash +++ b/.ci-scripts/release/arm64-unknown-linux-release.bash @@ -93,7 +93,7 @@ ASSET_DESCRIPTION="https://github.com/${GITHUB_REPOSITORY}" # Build application installation echo -e "\e[34mBuilding ${APPLICATION_NAME}...\e[0m" make install prefix="${BUILD_DIR}" arch=${CPU} \ - version="${APPLICATION_VERSION}" static=true linker=bfd + version="${APPLICATION_VERSION}" static=true # Package it all up echo -e "\e[34mCreating .tar.gz of ${APPLICATION_NAME}...\e[0m" diff --git a/.ci-scripts/release/x86-64-unknown-linux-nightly.bash b/.ci-scripts/release/x86-64-unknown-linux-nightly.bash index 93e83fa..b49dfce 100755 --- a/.ci-scripts/release/x86-64-unknown-linux-nightly.bash +++ b/.ci-scripts/release/x86-64-unknown-linux-nightly.bash @@ -93,7 +93,7 @@ ASSET_DESCRIPTION="https://github.com/${GITHUB_REPOSITORY}" # Build application installation echo -e "\e[34mBuilding ${APPLICATION_NAME}...\e[0m" make install prefix="${BUILD_DIR}" arch=${ARCH} \ - version="${APPLICATION_VERSION}" static=true linker=bfd + version="${APPLICATION_VERSION}" static=true # Package it all up echo -e "\e[34mCreating .tar.gz of ${APPLICATION_NAME}...\e[0m" diff --git a/.ci-scripts/release/x86-64-unknown-linux-release.bash b/.ci-scripts/release/x86-64-unknown-linux-release.bash index 6361e4b..c0fa397 100755 --- a/.ci-scripts/release/x86-64-unknown-linux-release.bash +++ b/.ci-scripts/release/x86-64-unknown-linux-release.bash @@ -92,7 +92,7 @@ ASSET_DESCRIPTION="https://github.com/${GITHUB_REPOSITORY}" # Build application installation echo -e "\e[34mBuilding ${APPLICATION_NAME}...\e[0m" make install prefix="${BUILD_DIR}" arch=${ARCH} \ - version="${APPLICATION_VERSION}" static=true linker=bfd + version="${APPLICATION_VERSION}" static=true # Package it all up echo -e "\e[34mCreating .tar.gz of ${APPLICATION_NAME}...\e[0m" diff --git a/Makefile b/Makefile index 1cae07b..5551619 100644 --- a/Makefile +++ b/Makefile @@ -3,7 +3,6 @@ destdir ?= ${prefix} config ?= release arch ?= static ?= false -linker ?= BUNDLE := corral @@ -42,10 +41,6 @@ ifeq ($(static),true) LINKER += --static endif -ifneq ($(linker),) - LINKER += --link-ldcmd=$(linker) -endif - # Default to version from `VERSION` file but allowing overridding on the # make command line like: # make version="nightly-19710702"