Repository navigation
formdropdown - contentcontainer resize so it fits inside the border - #38707
JanGolicnik wants to merge 2 commits into
Conversation
|
can i request come guidance regarding CI, the same tests seem to run fine on my linux and I don't have a windows machine to test with. what can i do to fix this ? |
bdach
added
the
type/cosmetic
bdach
left a comment
bdach
left a comment
There was a problem hiding this comment.
Test failures are irrelevant in this case and as such fine to ignore.
|
|
||
| protected override void UpdateSize(Vector2 newSize) | ||
| { | ||
| ContentContainer.Height = newSize.Y - FormControlBackground.BORDER_THICKNESS * 4.0f; |
There was a problem hiding this comment.
Why times four? That's double of what's actually required to fix the issue, is it not?
There was a problem hiding this comment.
I set the margin to be BORDER_THICKNESS * 2 (line 302), so the height has to be minus twice that. Was just what i subjectively preferred cause the radius in the corner looks a bit off to me. Shouldve mentioned it in the PR. Should I change it to be exact ?
These are screenshots with the exact values
bdach
added
subjective
|
This makes content scrollable which wasn't before:
|
Fixed. I also removed the extra padding from previous comment while i was at it. |
Fix for #37047
The ContentContainer is always the same size as the MaskingContainer and since the borders are inset they get covered up by the items. The obvious solution of adding a padding to the MaskingContainer doesn't work cause it disables the borders. Would make sense updating with that if there is a known fix.
screenshots after:
