Skip to content

Commit 64479e7

Browse files
rschristianrschristian
committed
test: Updating test suite
1 parent 1039efb commit 64479e7

File tree

10 files changed

+96
-33
lines changed

10 files changed

+96
-33
lines changed

‎packages/cli/tests/build.test.js‎

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
const { join } = require('path');
1+
const { join, relative } = require('path');
22
const { access, mkdir, readdir, readFile, rename, unlink, writeFile } =
33
require('fs').promises;
44
const looksLike = require('html-looks-like');
55
const { create, build, buildFast } = require('./lib/cli');
6-
const { snapshot } = require('./lib/utils');
6+
const { expand, snapshot } = require('./lib/utils');
77
const { subject } = require('./lib/output');
88
const images = require('./images/build');
99
const minimatch = require('minimatch');
@@ -84,6 +84,26 @@ describe('preact build', () => {
8484
await expect(buildFast(dir)).resolves.not.toThrow();
8585
});
8686

87+
it('lazy loads routes with preact-iso `lazy`', async () => {
88+
let dir = await subject('lazy-load-iso');
89+
await buildFast(dir);
90+
91+
let output = await expand(join(dir, 'build')).then(arr => {
92+
return arr.map(x => relative(dir, x));
93+
});
94+
95+
let expected = [
96+
/build\/a\.chunk\.\w{5}\.js$/,
97+
/build\/a\.chunk\.\w{5}\.css$/,
98+
/build\/b\.chunk\.\w{5}\.js$/,
99+
/build\/b\.chunk\.\w{5}\.css$/,
100+
];
101+
102+
expected.forEach(pattern => {
103+
expect(output.find(file => pattern.test(file))).not.toBeUndefined();
104+
});
105+
});
106+
87107
it('should patch global location object', async () => {
88108
let dir = await subject('location-patch');
89109

@@ -342,7 +362,7 @@ describe('preact build', () => {
342362
});
343363
});
344364

345-
describe('prerender', () => {
365+
describe.skip('prerender', () => {
346366
prerenderUrlFiles.forEach(prerenderUrls => {
347367
it(`should prerender the routes provided with '${prerenderUrls}'`, async () => {
348368
let dir = await subject('multiple-prerendering');

‎packages/cli/tests/images/build.js‎

Lines changed: 23 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -9,40 +9,40 @@ exports.default = {
99

1010
'ssr-build/ssr-bundle.css': 1281,
1111
'ssr-build/ssr-bundle.css.map': 2070,
12-
'ssr-build/ssr-bundle.js': 9801,
13-
'ssr-build/ssr-bundle.js.map': 30625,
12+
'ssr-build/ssr-bundle.js': 14400,
13+
'ssr-build/ssr-bundle.js.map': 46078,
1414
'ssr-build/asset-manifest.json': 76,
1515

16-
'bundle.620ee.js': 21323,
17-
'bundle.620ee.js.map': 85534,
18-
'bundle.620ee.legacy.js': 22514,
19-
'bundle.620ee.legacy.js.map': 106422,
16+
'bundle.c7f4f.js': 26608,
17+
'bundle.c7f4f.js.map': 107005,
18+
'bundle.c7f4f.legacy.js': 28182,
19+
'bundle.c7f4f.legacy.js.map': 133666,
2020
'bundle.354c3.css': 945,
2121
'bundle.354c3.css.map': 1758,
2222

2323
'dom-polyfills.c88f4.legacy.js': 5252,
2424
'dom-polyfills.c88f4.legacy.js.map': 18836,
25-
'es-polyfills.legacy.js': 42540,
25+
'es-polyfills.legacy.js': 61323,
2626

2727
'favicon.ico': 15086,
2828
'index.html': 2263,
2929
'manifest.json': 455,
3030
'preact_prerender_data.json': 11,
3131
'asset-manifest.json': 943,
3232

33-
'route-home.chunk.4ad71.js': 339,
34-
'route-home.chunk.4ad71.js.map': 1811,
35-
'route-home.chunk.4ad71.legacy.js': 394,
36-
'route-home.chunk.4ad71.legacy.js.map': 2102,
37-
'route-home.chunk.6eaee.css': 112,
38-
'route-home.chunk.6eaee.css.map': 224,
39-
40-
'route-profile.chunk.6a61d.js': 2545,
41-
'route-profile.chunk.6a61d.js.map': 10268,
42-
'route-profile.chunk.6a61d.legacy.js': 2698,
43-
'route-profile.chunk.6a61d.legacy.js.map': 12894,
44-
'route-profile.chunk.0af3e.css': 118,
45-
'route-profile.chunk.0af3e.css.map': 231,
33+
'routes-home.chunk.66725.js': 348,
34+
'routes-home.chunk.66725.js.map': 1703,
35+
'routes-home.chunk.66725.legacy.js': 394,
36+
'routes-home.chunk.66725.legacy.js.map': 1991,
37+
'routes-home.chunk.4c05c.css': 112,
38+
'routes-home.chunk.4c05c.css.map': 224,
39+
40+
'routes-profile.chunk.948e4.js': 743,
41+
'routes-profile.chunk.948e4.js.map': 3272,
42+
'routes-profile.chunk.948e4.legacy.js': 910,
43+
'routes-profile.chunk.948e4.legacy.js.map': 3931,
44+
'routes-profile.chunk.0a57b.css': 118,
45+
'routes-profile.chunk.0a57b.css.map': 231,
4646
};
4747

4848
exports.prerender = {};
@@ -156,8 +156,10 @@ exports.template = `
156156
<body>
157157
<h1>Guess what</h1>
158158
<h2>This is an app with custom template</h2>
159+
<script type="isodata"></script>
159160
<script defer="defer" src="/bundle.\\w{5}.js"></script>
160161
<h2>This is an app with custom template</h2>
162+
<script type="isodata"></script>
161163
<script type="__PREACT_CLI_DATA__">%7B%22preRenderData%22:%7B%22url%22:%22/%22%7D%7D</script>
162164
<script crossorigin="anonymous" src="/bundle.\\w{5}.js" type="module"></script>
163165
<script nomodule="" src="/dom-polyfills.\\w{5}.legacy.js"></script>
@@ -182,6 +184,7 @@ exports.publicPath = `
182184
</head>
183185
<body>
184186
<h1>Public path test</h1>
187+
<script type="isodata"></script>
185188
<script type="__PREACT_CLI_DATA__">%7B%22preRenderData%22:%7B%22url%22:%22/%22%7D%7D</script>
186189
<script crossorigin="anonymous" src="/example-path/bundle.\\w{5}.js" type="module"></script>
187190
<script nomodule="" src="/example-path/dom-polyfills.\\w{5}.legacy.js"></script>

‎packages/cli/tests/subjects/lazy-load-iso/a.css‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
h1 {
2+
color: red;
3+
}

‎packages/cli/tests/subjects/lazy-load-iso/a.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import './a.css';
2+
3+
export default () => <h1>Lazy Load A</h1>;

‎packages/cli/tests/subjects/lazy-load-iso/b.css‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
h1 {
2+
color: blue;
3+
}

‎packages/cli/tests/subjects/lazy-load-iso/b.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import './b.css';
2+
3+
export default () => <h1>Lazy Load B</h1>;

‎packages/cli/tests/subjects/lazy-load-iso/index.js‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
import { LocationProvider, Router } from 'preact-iso/router';
2+
import { default as lazy, ErrorBoundary } from 'preact-iso/lazy';
3+
4+
// Asynchronous, code-splitted:
5+
const A = lazy(() => import('./a.js'));
6+
const B = lazy(() => import('./b.js'));
7+
8+
export default function App() {
9+
return (
10+
<LocationProvider>
11+
<ErrorBoundary>
12+
<Router>
13+
<A path="/" />
14+
<B path="/b" />
15+
</Router>
16+
</ErrorBoundary>
17+
</LocationProvider>
18+
);
19+
}

‎packages/cli/tests/subjects/lazy-load-iso/package.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"private": true,
3+
"name": "preact-lazy-load-iso"
4+
}

‎packages/cli/tests/subjects/location-patch/index.js‎

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,19 @@
11
export default () => {
2+
// Uses WHATWG URL API
3+
// https://nodejs.org/api/url.html#the-whatwg-url-api
24
if (
3-
location.protocol === undefined ||
4-
location.slashes === undefined ||
5-
location.auth === undefined ||
5+
location.hash === undefined ||
66
location.host === undefined ||
7-
location.port === undefined ||
87
location.hostname === undefined ||
9-
location.hash === undefined ||
10-
location.query === undefined ||
8+
location.href === undefined ||
9+
location.origin === undefined ||
10+
location.password === undefined ||
1111
location.pathname === undefined ||
12-
location.path === undefined ||
13-
location.href === undefined
12+
location.port === undefined ||
13+
location.protocol === undefined ||
14+
location.search === undefined ||
15+
location.searchParams === undefined ||
16+
location.username === undefined
1417
) {
1518
throw new Error('Incomplete Location object');
1619
}

‎packages/create-cli/lib/commands/create.js‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,10 @@ exports.create = async function create(repo, dest, argv) {
3535
if (!repo.includes('/')) {
3636
repo = `preactjs-templates/${repo}`;
3737

38-
// TODO: Remove this after updating all templates
39-
if (repo.endsWith('default') || repo.endsWith('typescript')) {
38+
// TODO: This is an awful hack but necessary to test with
39+
if (repo.endsWith('default')) {
40+
repo += '#experimental/preact-iso';
41+
} else if (repo.endsWith('typescript')) {
4042
repo += '#next';
4143
}
4244
}

0 commit comments

Comments
 (0)