Document time of day bug in RandomUnseenWildMon #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for finding and fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When porting the function
RandomUnseenWildMonto Rust (for Rustic Crystal) I noticed a logic error where it will always compare the potentially rare pokemon to the the first 4 morning encounters to see it is indeed rare.I haven't seen the issue while playing since it's quite rare, and would be hard to notice unless you know what to look for.
Looking thru the grass data, it looks like it could happen for e.g.
ROUTE_30in the night. If it first picked slot 6HOOTHOOTit would tell the player of the rare Hoothoot, even though slot 2 & 4 also containsHOOTHOOTin the night...