[Silabs] Updated deprecated APIs to their recommended alternatives #42295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates deprecated Silicon Labs SDK APIs to their recommended alternatives to resolve deprecation warnings during compilation. The changes affect WiFi configuration and GPIO driver functions.
Key Changes:
- WiFi SDK API updates: Replaced deprecated
sl_si91x_prefixed functions withsl_wifi_equivalents - Type updates: Changed performance profile types from
sl_si91x_tosl_wifi_system_variants - GPIO driver update: Replaced deprecated interrupt masking function with its current alternative
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/platform/silabs/wifi/SiWx/WifiInterfaceImpl.cpp | Updated WiFi join configuration API call, performance profile return type documentation, and function signature with corresponding type changes |
| src/platform/silabs/SiWx/SiWxPlatformInterface.h | Replaced deprecated GPIO interrupt masking function with recommended alternative |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly updates several deprecated Silicon Labs APIs to their recommended alternatives, addressing deprecation warnings. The changes are straightforward replacements of function names and types, such as sl_si91x_gpio_driver_mask_uulp_npss_interrupt to sl_si91x_gpio_driver_mask_set_uulp_npss_interrupt and sl_si91x_performance_profile_t to sl_wifi_system_performance_profile_t. The implementation is correct and follows the stated intent of the PR. The code looks good, and I have no further suggestions.
|
PR #42295: Size comparison from e333758 to dae03a1 Full report (32 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
chirag-silabs
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates deprecated APIs to their recommended alternatives across platform and shell components to resolve deprecation warnings. The changes replace deprecated Silicon Labs WiFi SDK and GPIO driver functions with their current equivalents.
Key Changes:
sl_si91x_set_join_configurationwithsl_wifi_set_join_configurationin WiFi interfacesl_si91x_performance_profile_ttype tosl_wifi_system_performance_profile_tsl_si91x_gpio_driver_mask_uulp_npss_interruptwithsl_si91x_gpio_driver_mask_set_uulp_npss_interruptRelated issues
N/A
Testing
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines