gh-140677 Improve heatmap colors #142241
Merged
gh-140677 Improve heatmap colors #142241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, colors were generated in HeatmapCollector based on intensity, and the same colors were used for both light and dark themes. As a result, the displayed colors didn’t always match the color legend for the selected theme. To fix this, we now compute only the intensity for both self and total samples in HeatmapCollector. The actual color is chosen later based on that intensity and the active theme, ensuring the lines correctly follow the theme-specific color legend.
The _color_cache itself is no longer needed because colors are no longer generated in HeatmapCollector.
Member
|
I have refactored things a bit to clean some duplication but other than that LGTM |
pablogsal
approved these changes
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, colors were generated in
HeatmapCollectorbased on intensity, and the same colors were used for both light and dark themes. As a result, the displayed colors didn’t always match the color legend for the selected theme.To fix this, we now compute only the intensity for both self and total samples in
HeatmapCollector. The actual color is chosen later based on that intensity and the active theme, ensuring the lines correctly follow the theme-specific color legend.