Skip to content

Commit ead0a07

Browse files
mzzchyfacebook-github-bot
authored andcommitted
use pre-built perfetto trace (#1195)
Summary: Discussed with sraikund16, instead of building from proto file, we pre-built the header and cpp so that we could use it in both OSS and FB flow Differential Revision: D88919648
1 parent 199cff7 commit ead0a07

File tree

4 files changed

+658462
-6
lines changed

4 files changed

+658462
-6
lines changed

libkineto/src/PerfettoTraceBuilder.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#include "Logger.h"
1515
#include "TraceSpan.h"
1616
#include "output_base.h"
17-
#include "parfait/protos/perfetto/trace/perfetto_trace.pb.h"
1817

1918
namespace KINETO_NAMESPACE {
2019

libkineto/src/PerfettoTraceBuilder.h

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,17 @@
88

99
#pragma once
1010

11-
#include <parfait/protos/perfetto/trace/perfetto_trace.pb.h>
11+
#include <kineto/libkineto/src/perfetto_trace.pb.h>
1212
#include <string>
1313
#include <unordered_map>
1414
#include "output_base.h"
1515

1616
namespace KINETO_NAMESPACE {
1717

1818
// PerfettoTraceBuilder is a helper class that constructs Perfetto protobuf
19-
// traces It provides similar interface to ActivityLogger but builds a Perfetto
20-
// trace object This class is designed to be used alongside ChromeTraceLogger to
21-
// generate both JSON and Perfetto protobuf traces
19+
// traces It provides similar interface to ActivityLogger but builds a
20+
// Perfetto trace object This class is designed to be used alongside
21+
// ChromeTraceLogger to generate both JSON and Perfetto protobuf traces
2222
class PerfettoTraceBuilder {
2323
public:
2424
PerfettoTraceBuilder();
@@ -76,7 +76,8 @@ class PerfettoTraceBuilder {
7676
// Map from (deviceId, resourceId, threadId) to track UUID
7777
std::unordered_map<std::string, TrackDescriptor*> trackUuids_;
7878

79-
// Map from deviceId to process TrackDescriptor pointer for later name updates
79+
// Map from deviceId to process TrackDescriptor pointer for later name
80+
// updates
8081
std::unordered_map<int64_t, TrackDescriptor*> deviceProcessDescriptors_;
8182

8283
// Map from Main Thread to child thread

0 commit comments

Comments
 (0)