Skip to content

Commit 357f5ed

Browse files
committed
[simple_fsdp] Turn on bucketing by default
ghstack-source-id: ab5fdb2 Pull Request resolved: #2103
1 parent 53e949c commit 357f5ed

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

torchtitan/experiments/simple_fsdp/backend.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@ def get_compile_backend_with_passes(
5252
def aot_eager_autobucketing_reordering_pass(
5353
gm: torch.fx.GraphModule, example_inputs: Any
5454
) -> torch.fx.GraphModule:
55-
schedule_overlap_bucketing(gm)
55+
schedule_overlap_bucketing(
56+
gm, collective_bucketing=True, insert_overlap_deps=True
57+
)
5658
gm.recompile()
5759
return gm
5860

@@ -67,7 +69,11 @@ def aot_eager_autobucketing_reordering_pass(
6769
def inductor_autobucketing_reordering_pass(
6870
gm: torch.fx.Graph,
6971
) -> torch.fx.GraphModule:
70-
return schedule_overlap_bucketing(gm.owning_module)
72+
return schedule_overlap_bucketing(
73+
gm.owning_module,
74+
collective_bucketing=True,
75+
insert_overlap_deps=True,
76+
)
7177

7278
dist_opts.insert_overlap_deps = True
7379
torch._inductor.config.reorder_for_peak_memory = False

0 commit comments

Comments
 (0)