Skip to content

Commit 5b73d25

Browse files
author
Barnabás Pőcze
committed
utils: ipc: Do not duplicate signals in proxy object
The specific proxy type (see `module_ipa_proxy.h.tmpl`) inherits `IPAProxy`, the specific interface type, and `Object`. The interface type already provides public definitions of the necessary `Signal<>` objects (see `module_ipa_interface.h.tmpl`), so do not duplicate them. Signed-off-by: Barnabás Pőcze <[email protected]> Reviewed-by: Paul Elder <[email protected]> Reviewed-by: Laurent Pinchart <[email protected]>
1 parent 3e4de5f commit 5b73d25

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,6 @@ public:
4444
{{proxy_funcs.func_sig(proxy_name, method, "", false, true)|indent(8, true)}};
4545
{% endfor %}
4646

47-
{%- for method in interface_event.methods %}
48-
Signal<
49-
{%- for param in method.parameters -%}
50-
{{"const " if not param|is_pod}}{{param|name}}{{" &" if not param|is_pod and not param|is_enum}}
51-
{{- ", " if not loop.last}}
52-
{%- endfor -%}
53-
> {{method.mojom_name}};
54-
{% endfor %}
55-
5647
private:
5748
void recvMessage(const IPCMessage &data);
5849

0 commit comments

Comments
 (0)