Forward-declare private-target types in RuntimeScheduler.h (#58271)

Summary:

`RuntimeScheduler.h` included `PerformanceEntryReporter.h` and `ShadowTreeRevisionConsistencyManager.h` solely to name two pointer parameters. Both belong to targets classified private under the three-tier C++ stable API visibility model, and `RuntimeScheduler.h` is reachable from for-frameworks headers, so a consumer opting into `RN_STRICT_API` got a hard error out of `PrivateGuard.h` from a header they never named — one that neither `RN_ALLOW_FRAMEWORKS` nor an umbrella include can suppress.

Replace both with forward declarations, and drop the now-redundant `ShadowTreeRevisionConsistencyManager.h` include from the two scheduler forks, which take the declarations from `RuntimeScheduler.h`. Two translation units were relying on the transitive include and now include the header directly: `RuntimeScheduler_Modern.cpp` (calls `reportLongTask`) and `ReactInstance.cpp` (calls `PerformanceEntryReporter::getInstance`). No build wiring changes — both targets already depend on `react/performance/timeline` and `react/renderer/consistency` for their own sources.

Changelog:
[General][Changed] - `RuntimeScheduler.h` no longer transitively includes `PerformanceEntryReporter.h` or `ShadowTreeRevisionConsistencyManager.h`; include them directly where the complete types are needed

Differential Revision: D117838094

Author: j-piasecki

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler.h

@@ -11,17 +11,23 @@
 
 #include <ReactCommon/RuntimeExecutor.h>
 #include <jsi/hermes-interfaces.h>
-#include <react/performance/timeline/PerformanceEntryReporter.h>
-#include <react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h>
 #include <react/renderer/runtimescheduler/SchedulerPriorityUtils.h>
 #include <react/renderer/runtimescheduler/Task.h>
 #include <react/timing/primitives.h>
+#include <cstdint>
 #include "RuntimeSchedulerEventTimingDelegate.h"
 #include "RuntimeSchedulerIntersectionObserverDelegate.h"
 #include "RuntimeSchedulerResizeObserverDelegate.h"
 
 namespace facebook::react {
 
+// Both live in private targets (react/performance/timeline,
+// react/renderer/consistency). This header is reachable from for-frameworks
+// headers, so they must stay forward-declared here — including them would
+// make every consumer of a for-frameworks header pull in a private one.
+class PerformanceEntryReporter;
+class ShadowTreeRevisionConsistencyManager;
+
 using RuntimeSchedulerRenderingUpdate = std::function<void()>;
 using SurfaceId = int32_t;
 

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Legacy.h

@@ -12,7 +12,6 @@
 #ifndef RCT_REMOVE_LEGACY_ARCH
 
 #include <ReactCommon/RuntimeExecutor.h>
-#include <react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h>
 #include <react/renderer/runtimescheduler/RuntimeScheduler.h>
 #include <react/renderer/runtimescheduler/Task.h>
 #include <atomic>

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.cpp

@@ -10,6 +10,7 @@
 #include <ReactCommon/RuntimeExecutorSyncUIThreadUtils.h>
 #include <cxxreact/TraceSection.h>
 #include <jsinspector-modern/tracing/EventLoopReporter.h>
+#include <react/performance/timeline/PerformanceEntryReporter.h>
 #include <react/renderer/consistency/ScopedShadowTreeRevisionLock.h>
 #include <react/timing/primitives.h>
 #include <react/utils/OnScopeExit.h>

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.h

@@ -10,7 +10,6 @@
 #include <react/cxxstableapi/FrameworksGuard.h>
 
 #include <ReactCommon/RuntimeExecutor.h>
-#include <react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h>
 #include <react/renderer/runtimescheduler/RuntimeScheduler.h>
 #include <react/renderer/runtimescheduler/Task.h>
 #include <atomic>

packages/react-native/ReactCommon/react/runtime/ReactInstance.cpp

@@ -18,6 +18,7 @@
 #include <jsi/instrumentation.h>
 #include <jsinspector-modern/HostTarget.h>
 #include <react/featureflags/ReactNativeFeatureFlags.h>
+#include <react/performance/timeline/PerformanceEntryReporter.h>
 #include <react/renderer/runtimescheduler/RuntimeSchedulerBinding.h>
 #include <react/runtime/JSRuntimeBindings.h>
 #include <react/timing/primitives.h>