refactor: heap-allocate clipPath via unique_ptr

Author: marcinszalski-callstack

packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm

@@ -1375,9 +1375,9 @@ - (void)invalidateLayer
   self.currentContainerView.layer.mask = nil;
 
   // Handle clip-path property
-  if (_props->clipPath.has_value()) {
+  if (_props->clipPath != nullptr) {
 		if (auto yogaStylableProps = std::static_pointer_cast<const YogaStylableProps>(_props)) {
-			CALayer *maskLayer = [RCTClipPathUtils createClipPathLayer:_props->clipPath.value()
+			CALayer *maskLayer = [RCTClipPathUtils createClipPathLayer:*_props->clipPath
 																									 layoutMetrics:_layoutMetrics
 																							 yogaStylableProps:*yogaStylableProps.get()
 																													bounds:layer.bounds

packages/react-native/ReactCommon/react/renderer/components/view/BaseViewProps.cpp

@@ -323,12 +323,19 @@ BaseViewProps::BaseViewProps(
           "removeClippedSubviews",
           sourceProps.removeClippedSubviews,
           false)),
-      clipPath(convertRawProp(
-          context,
-          rawProps,
-          "clipPath",
-          sourceProps.clipPath,
-          {})) {}
+      clipPath([&]() -> std::unique_ptr<ClipPath> {
+        auto optionalClipPath = convertRawProp(
+            context,
+            rawProps,
+            "clipPath",
+            sourceProps.clipPath
+                ? std::make_optional(*sourceProps.clipPath)
+                : std::nullopt,
+            std::nullopt);
+        return optionalClipPath
+            ? std::make_unique<ClipPath>(std::move(*optionalClipPath))
+            : nullptr;
+      }()) {}
 
 #define VIEW_EVENT_CASE(eventType)                      \
   case CONSTEXPR_RAW_PROPS_KEY_HASH("on" #eventType): { \
@@ -391,7 +398,14 @@ void BaseViewProps::setProp(
     RAW_SET_PROP_SWITCH_CASE_BASIC(filter);
     RAW_SET_PROP_SWITCH_CASE_BASIC(boxShadow);
     RAW_SET_PROP_SWITCH_CASE_BASIC(mixBlendMode);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(clipPath);
+    case CONSTEXPR_RAW_PROPS_KEY_HASH("clipPath"): {
+      std::optional<ClipPath> parsedClipPath;
+      fromRawValue(context, value, parsedClipPath);
+      clipPath = parsedClipPath
+          ? std::make_unique<ClipPath>(std::move(*parsedClipPath))
+          : nullptr;
+      return;
+    }
     // events field
     VIEW_EVENT_CASE(PointerEnter);
     VIEW_EVENT_CASE(PointerEnterCapture);

packages/react-native/ReactCommon/react/renderer/components/view/BaseViewProps.h

@@ -27,6 +27,7 @@
 #include <react/renderer/graphics/Isolation.h>
 #include <react/renderer/graphics/Transform.h>
 
+#include <memory>
 #include <optional>
 
 namespace facebook::react {
@@ -112,7 +113,7 @@ class BaseViewProps : public YogaStylableProps, public AccessibilityProps {
 
   bool removeClippedSubviews{false};
 
-  std::optional<ClipPath> clipPath{};
+  std::unique_ptr<ClipPath> clipPath{};
 
 #pragma mark - Convenience Methods
 

packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.cpp

@@ -59,7 +59,7 @@ void ViewShadowNode::initialize() noexcept {
       viewProps.mixBlendMode != BlendMode::Normal ||
       viewProps.isolation == Isolation::Isolate ||
       HostPlatformViewTraitsInitializer::formsStackingContext(viewProps) ||
-      !viewProps.accessibilityOrder.empty() || viewProps.clipPath.has_value();
+      !viewProps.accessibilityOrder.empty() || viewProps.clipPath != nullptr;
 
   bool formsView = formsStackingContext ||
       isColorMeaningful(viewProps.backgroundColor) || hasBorder() ||