Scope the TextInput spannable cache to the React instance (#58869)

Summary:
WARNING: Generated by Autopilot (alpha) — review carefully, verify the underlying claim before accepting.
Agent: React Native Agent (Bugs) | Trajectory: https://www.internalfb.com/intern/devai/devmate/inspector/dea12476-b7e6-441b-8ebb-bd79b2de520a/ | SC job: https://www.internalfb.com/intern/sandcastle/instance/49539596621165635/

 ---

Pull Request resolved: #58869

On Fabric, `ReactEditText` caches its spannable in `TextLayoutManager` keyed by react tag, and the shadow node's state keeps that tag as `cachedAttributedStringId` to re-measure against. The cache was a single process-global map keyed only by tag. React tags restart for every new React instance, so after a reload the old and new instances can use the same tags in the same map: the new instance can read the old instance's spannable, and when an old `ReactEditText` is finalized it removes the new view's entry. The next cached measure then fails `checkNotNull` in `getOrCreateSpannableForText` with "Required value was null".

This change gives each React instance its own spannable cache:
- `TextLayoutManager` keeps one map per `ReactApplicationContext`. `FabricUIManager` creates it in its constructor and removes it in `invalidate()`.
- `FabricUIManager.measureText` passes its own context, so a cached measure only looks in that instance's map.
- `ReactEditText` writes to and evicts from the map of the context it was created with (`ThemedReactContext.reactApplicationContext`). Create, destroy, read and write all resolve the key through one helper, so a view's `ThemedReactContext` and `FabricUIManager`'s `ReactApplicationContext` always hit the same map. After teardown, an old view's set or evict does nothing because its map is gone.
- A layout that started before `invalidate()` can still reach `measureText` after the map is removed. In that case the cached measure returns a 0x0 measurement instead of throwing, because the cache-id `MapBuffer` carries only the id and there is nothing to rebuild from. The result belongs to an instance that is going away. A missing entry in a live map still fails `checkNotNull`.

This replaces the previous version of this diff, where `finalize()` only evicted the spannable the instance itself had cached. Per-tag eviction still happens in `finalize()`, but now only within the view's own instance, where tags are never reused. I did not move eviction to `onDropViewInstance`: a commit whose layout is still running on a background thread can measure a TextInput after the UI thread has already processed that view's delete, so evicting right away would add a new way to hit the same `checkNotNull`.

Changelog:
[Android][Fixed] - Fix TextInput measurement crash ("Required value was null") after a React instance reload, by scoping the cached TextInput spannables to the React instance

Reviewed By: zeyap

Differential Revision: D122870300

Author: Autopilot Bot

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java

@@ -259,6 +259,7 @@ public FabricUIManager(
 
     mViewManagerRegistry = viewManagerRegistry;
     mReactApplicationContext.registerComponentCallbacks(viewManagerRegistry);
+    TextLayoutManager.createSpannableCache(mReactApplicationContext);
   }
 
   @Override
@@ -496,6 +497,7 @@ public void invalidate() {
     }
     mBinding = null;
 
+    TextLayoutManager.destroySpannableCache(mReactApplicationContext);
     ViewManagerPropertyUpdater.clear();
   }
 
@@ -566,7 +568,8 @@ private NativeArray measureLines(
             textViewManager instanceof ReactTextViewManagerCallback
                 ? (ReactTextViewManagerCallback) textViewManager
                 : null,
-            mTextEffectRegistry);
+            mTextEffectRegistry,
+            mReactApplicationContext);
   }
 
   public @Nullable Integer getColor(int surfaceId, String[] resourcePaths) {
@@ -658,7 +661,8 @@ public long measureText(
             ? (ReactTextViewManagerCallback) textViewManager
             : null,
         attachmentsPositions,
-        mTextEffectRegistry);
+        mTextEffectRegistry,
+        mReactApplicationContext);
   }
 
   @AnyThread

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.kt

@@ -28,8 +28,10 @@ import android.view.View
 import androidx.annotation.VisibleForTesting
 import com.facebook.common.logging.FLog
 import com.facebook.infer.annotation.Assertions
+import com.facebook.react.bridge.Arguments
 import com.facebook.react.bridge.JavaOnlyArray
 import com.facebook.react.bridge.JavaOnlyMap
+import com.facebook.react.bridge.ReactContext
 import com.facebook.react.bridge.ReadableMap
 import com.facebook.react.bridge.WritableArray
 import com.facebook.react.common.ReactConstants
@@ -42,6 +44,7 @@ import com.facebook.react.uimanager.PixelUtil
 import com.facebook.react.uimanager.PixelUtil.dpToPx
 import com.facebook.react.uimanager.PixelUtil.pxToDp
 import com.facebook.react.uimanager.ReactAccessibilityDelegate
+import com.facebook.react.uimanager.ThemedReactContext
 import com.facebook.react.util.AndroidVersion.VERSION_CODE_VANILLA_ICE_CREAM
 import com.facebook.react.views.text.internal.span.CustomLetterSpacingSpan
 import com.facebook.react.views.text.internal.span.CustomLineHeightSpan
@@ -115,7 +118,11 @@ internal object TextLayoutManager {
 
   private const val TEXT_WIDTH_MODE_LONGEST_LINE = "longest-line"
 
-  private val tagToSpannableCache = ConcurrentHashMap<Int, Spannable>()
+  // TextInput spannables keyed by react tag, one map per React instance. Tags restart from the same
+  // value in every instance, so entries must not be shared across instances. FabricUIManager
+  // creates and destroys the map for its ReactApplicationContext.
+  private val tagToSpannableCaches =
+      ConcurrentHashMap<ReactContext, ConcurrentHashMap<Int, Spannable>>()
 
   // These wrappers mirror Android 15 APIs but use reflection because some internal targets still
   // compile against Android 14. They return null when the API is unavailable or cannot be invoked.
@@ -180,12 +187,35 @@ internal object TextLayoutManager {
         null
       }
 
-  fun setCachedSpannableForTag(reactTag: Int, sp: Spannable) {
-    tagToSpannableCache[reactTag] = sp
+  // Views hold a ThemedReactContext while FabricUIManager holds the ReactApplicationContext it
+  // wraps. Every cache access goes through this so both resolve to the same key.
+  private fun spannableCacheKey(reactContext: ReactContext): ReactContext =
+      if (reactContext is ThemedReactContext) reactContext.reactApplicationContext else reactContext
+
+  @JvmStatic
+  fun createSpannableCache(reactContext: ReactContext) {
+    tagToSpannableCaches[spannableCacheKey(reactContext)] = ConcurrentHashMap()
+  }
+
+  @JvmStatic
+  fun destroySpannableCache(reactContext: ReactContext) {
+    tagToSpannableCaches.remove(spannableCacheKey(reactContext))
+  }
+
+  private fun getSpannableCache(reactContext: ReactContext): ConcurrentHashMap<Int, Spannable>? =
+      tagToSpannableCaches[spannableCacheKey(reactContext)]
+
+  // Returns null once FabricUIManager.invalidate() has removed the instance's map. A missing entry
+  // in a live map is an eviction bug, so it still fails.
+  internal fun getCachedSpannable(reactContext: ReactContext, reactTag: Int): Spannable? =
+      getSpannableCache(reactContext)?.let { checkNotNull(it[reactTag]) }
+
+  fun setCachedSpannableForTag(reactContext: ReactContext, reactTag: Int, sp: Spannable) {
+    getSpannableCache(reactContext)?.put(reactTag, sp)
   }
 
-  fun deleteCachedSpannableForTag(reactTag: Int) {
-    tagToSpannableCache.remove(reactTag)
+  fun deleteCachedSpannableForTag(reactContext: ReactContext, reactTag: Int) {
+    getSpannableCache(reactContext)?.remove(reactTag)
   }
 
   fun isRTL(attributedString: MapBuffer): Boolean {
@@ -765,25 +795,15 @@ internal object TextLayoutManager {
       attributedString: MapBuffer,
       reactTextViewManagerCallback: ReactTextViewManagerCallback?,
       textEffectRegistry: TextEffectRegistry?,
-  ): Spannable {
-    val text: Spannable?
-    if (attributedString.contains(AS_KEY_CACHE_ID)) {
-      val cacheId = attributedString.getInt(AS_KEY_CACHE_ID)
-      text = checkNotNull(tagToSpannableCache[cacheId])
-    } else {
-      text =
-          createSpannableFromAttributedString(
-              assets,
-              fontWeightAdjustment,
-              attributedString.getMapBuffer(AS_KEY_FRAGMENTS),
-              reactTextViewManagerCallback,
-              null,
-              textEffectRegistry,
-          )
-    }
-
-    return text
-  }
+  ): Spannable =
+      createSpannableFromAttributedString(
+          assets,
+          fontWeightAdjustment,
+          attributedString.getMapBuffer(AS_KEY_FRAGMENTS),
+          reactTextViewManagerCallback,
+          null,
+          textEffectRegistry,
+      )
 
   @OptIn(UnstableReactNativeAPI::class)
   private fun createSpannableFromAttributedString(
@@ -1091,20 +1111,28 @@ internal object TextLayoutManager {
       heightYogaMeasureMode: YogaMeasureMode,
       reactTextViewManagerCallback: ReactTextViewManagerCallback?,
       textEffectRegistry: TextEffectRegistry? = null,
-  ): Layout {
-    val text =
-        getOrCreateSpannableForText(
-            assets,
-            fontWeightAdjustment,
-            attributedString,
-            reactTextViewManagerCallback,
-            textEffectRegistry,
-        )
-
+      spannableCacheOwner: ReactContext? = null,
+  ): Layout? {
+    val text: Spannable
     val paint: TextPaint
     if (attributedString.contains(AS_KEY_CACHE_ID)) {
+      // A layout that started before FabricUIManager.invalidate() can still measure here after the
+      // instance's cache is gone. There is nothing to measure, and the result is discarded. Without
+      // an owner there is no cache to read either.
+      text =
+          spannableCacheOwner?.let {
+            getCachedSpannable(it, attributedString.getInt(AS_KEY_CACHE_ID))
+          } ?: return null
       paint = text.getSpans(0, 0, ReactTextPaintHolderSpan::class.java)[0].textPaint
     } else {
+      text =
+          getOrCreateSpannableForText(
+              assets,
+              fontWeightAdjustment,
+              attributedString,
+              reactTextViewManagerCallback,
+              textEffectRegistry,
+          )
       val baseTextAttributes =
           TextAttributeProps.fromMapBuffer(attributedString.getMapBuffer(AS_KEY_BASE_ATTRIBUTES))
       paint = scratchPaintWithAttributes(baseTextAttributes, assets, fontWeightAdjustment)
@@ -1463,6 +1491,7 @@ internal object TextLayoutManager {
       reactTextViewManagerCallback: ReactTextViewManagerCallback?,
       attachmentsPositions: FloatArray?,
       textEffectRegistry: TextEffectRegistry? = null,
+      spannableCacheOwner: ReactContext? = null,
   ): Long =
       measureText(
           assets,
@@ -1476,6 +1505,7 @@ internal object TextLayoutManager {
           reactTextViewManagerCallback,
           attachmentsPositions,
           textEffectRegistry,
+          spannableCacheOwner,
       )
 
   @JvmStatic
@@ -1492,6 +1522,7 @@ internal object TextLayoutManager {
       reactTextViewManagerCallback: ReactTextViewManagerCallback?,
       attachmentsPositions: FloatArray?,
       textEffectRegistry: TextEffectRegistry? = null,
+      spannableCacheOwner: ReactContext? = null,
   ): Long {
     // TODO(5578671): Handle text direction (see View#getTextDirectionHeuristic)
     val layout =
@@ -1506,7 +1537,8 @@ internal object TextLayoutManager {
             heightYogaMeasureMode,
             reactTextViewManagerCallback,
             textEffectRegistry,
-        )
+            spannableCacheOwner,
+        ) ?: return YogaMeasureOutput.make(0f, 0f)
 
     val maximumNumberOfLines =
         if (paragraphAttributes.contains(PA_KEY_MAX_NUMBER_OF_LINES))
@@ -1775,6 +1807,7 @@ internal object TextLayoutManager {
       height: Float,
       reactTextViewManagerCallback: ReactTextViewManagerCallback?,
       textEffectRegistry: TextEffectRegistry? = null,
+      spannableCacheOwner: ReactContext? = null,
   ): WritableArray =
       measureLines(
           assetManager,
@@ -1785,6 +1818,7 @@ internal object TextLayoutManager {
           height,
           reactTextViewManagerCallback,
           textEffectRegistry,
+          spannableCacheOwner,
       )
 
   @JvmStatic
@@ -1798,6 +1832,7 @@ internal object TextLayoutManager {
       height: Float,
       reactTextViewManagerCallback: ReactTextViewManagerCallback?,
       textEffectRegistry: TextEffectRegistry? = null,
+      spannableCacheOwner: ReactContext? = null,
   ): WritableArray {
     val layout =
         createLayoutForMeasurement(
@@ -1811,7 +1846,8 @@ internal object TextLayoutManager {
             YogaMeasureMode.EXACTLY,
             reactTextViewManagerCallback,
             textEffectRegistry,
-        )
+            spannableCacheOwner,
+        ) ?: return Arguments.createArray()
     return FontMetricsUtil.getFontMetrics(
         layout.text,
         layout,

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.kt

@@ -9,6 +9,7 @@ package com.facebook.react.views.textinput
 
 import android.annotation.SuppressLint
 import android.content.Context
+import android.content.ContextWrapper
 import android.content.res.Configuration
 import android.graphics.Canvas
 import android.graphics.Color
@@ -46,6 +47,7 @@ import androidx.core.graphics.withTranslation
 import androidx.core.util.Predicate
 import androidx.core.view.ViewCompat
 import com.facebook.common.logging.FLog
+import com.facebook.react.bridge.ReactContext
 import com.facebook.react.bridge.ReactSoftExceptionLogger.logSoftException
 import com.facebook.react.common.ReactConstants
 import com.facebook.react.common.assets.ReactFontManager
@@ -292,7 +294,14 @@ public open class ReactEditText public constructor(context: Context) : AppCompat
     if (DEBUG_MODE) {
       FLog.e(TAG, "finalize[$id] delete cached spannable")
     }
-    TextLayoutManager.deleteCachedSpannableForTag(id)
+    spannableCacheOwner()?.let { TextLayoutManager.deleteCachedSpannableForTag(it, id) }
+  }
+
+  // Same lookup as UIManagerHelper.getReactContext, but returns null instead of throwing
+  // ClassCastException, so finalize() cannot throw on the finalizer thread.
+  private fun spannableCacheOwner(): ReactContext? {
+    val context = context
+    return context as? ReactContext ?: (context as? ContextWrapper)?.baseContext as? ReactContext
   }
 
   // After the text changes inside an EditText, TextView checks if a layout() has been requested.
@@ -1220,7 +1229,7 @@ public open class ReactEditText public constructor(context: Context) : AppCompat
         sb.length,
         Spannable.SPAN_INCLUSIVE_INCLUSIVE,
     )
-    TextLayoutManager.setCachedSpannableForTag(id, sb)
+    spannableCacheOwner()?.let { TextLayoutManager.setCachedSpannableForTag(it, id, sb) }
   }
 
   public fun setEventDispatcher(eventDispatcher: EventDispatcher?) {