Skip to content

Commit 3993c43

Browse files
j-piaseckifacebook-github-bot
authored andcommitted
Retier react/renderer/uimanager headers
Summary: Make `AppRegistryBinding.h`, `LayoutEventEmitter.h` and the deprecated `SurfaceRegistryBinding.h` private; they are only used inside React Native. `UIManagerViewTransitionDelegate.h` now reaches `Float.h` through the `<React/Graphics.h>` umbrella instead of including it directly, since `Float.h` is public and its guard rejects direct includes from for-frameworks headers. Changelog: [Internal] Differential Revision: D123391983
1 parent 44ffdba commit 3993c43

4 files changed

Lines changed: 5 additions & 4 deletions

File tree

‎packages/react-native/ReactCommon/react/renderer/uimanager/AppRegistryBinding.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/FrameworksGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <React/RendererCore.h>
1313

‎packages/react-native/ReactCommon/react/renderer/uimanager/LayoutEventEmitter.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/FrameworksGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <react/renderer/uimanager/UIManagerCommitHook.h>
1313

‎packages/react-native/ReactCommon/react/renderer/uimanager/SurfaceRegistryBinding.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#warning "The SurfaceRegistryBinding.h header has been renamed to AppRegistryBinding.h"
1113

1214
#include <react/renderer/uimanager/AppRegistryBinding.h>

‎packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerViewTransitionDelegate.h‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,14 @@
99

1010
#include <react/cxxstableapi/FrameworksGuard.h>
1111

12+
#include <React/Graphics.h>
1213
#include <React/RendererCore.h>
1314

1415
#include <functional>
1516
#include <memory>
1617
#include <optional>
1718
#include <string>
1819

19-
#include <react/renderer/graphics/Float.h>
20-
2120
namespace facebook::react {
2221

2322
class UIManagerViewTransitionDelegate {

0 commit comments

Comments
 (0)